Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain: Make sure we're linting bin/eslint.js
Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
Ensured bin/eslint.js was linted (by adding a
bin/**/*.js
glob to Makefile.js and removing a line from .eslintignore). Then fixed lint errors.Is there anything you'd like reviewers to focus on?
I turned off
no-console
andno-process-exit
for the file, since we allow those in bin/eslint.js. Let me know if that's not okay (e.g.,console.log
invocations could be replaced by requiring and using the logger file we have).Also, this PR subsumes #7241 a bit, oops. If that gets merged first, I'll rebase the branch.