Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Lint bin/eslint.js #7243

Merged
merged 1 commit into from Sep 26, 2016
Merged

Chore: Lint bin/eslint.js #7243

merged 1 commit into from Sep 26, 2016

Conversation

platinumazure
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain: Make sure we're linting bin/eslint.js

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • n/a I've included tests for my change
  • n/a I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

Ensured bin/eslint.js was linted (by adding a bin/**/*.js glob to Makefile.js and removing a line from .eslintignore). Then fixed lint errors.

Is there anything you'd like reviewers to focus on?

I turned off no-console and no-process-exit for the file, since we allow those in bin/eslint.js. Let me know if that's not okay (e.g., console.log invocations could be replaced by requiring and using the logger file we have).

Also, this PR subsumes #7241 a bit, oops. If that gets merged first, I'll rebase the branch.

@eslintbot
Copy link

LGTM

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious - is there a reason we weren't already doing this?

Changes LGTM, but waiting to merge until we fix our currently failing CI tests.

@platinumazure
Copy link
Member Author

@kaicataldo I don't know why it wasn't being linted before. If there is a good reason for it, I hope I will learn of it before closing this PR 😄

Copy link
Member

@vitorbal vitorbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks!

@vitorbal vitorbal added accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing labels Sep 26, 2016
@gyandeeps gyandeeps merged commit d154204 into master Sep 26, 2016
@gyandeeps gyandeeps mentioned this pull request Sep 26, 2016
3 tasks
@platinumazure platinumazure deleted the lint-bin branch September 26, 2016 21:53
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants