correct eol-last desire value documentation

[chaintng]

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Please check each item to ensure your pull request is ready:

• I've read the pull request guide
• I've included tests for my change
• I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)
Correct desire eol-last value after this pull request #6952

Is there anything you'd like reviewers to focus on?
nope :)

[mention-bot]

@chaintan17, thanks for your PR! By analyzing the annotation information on this pull request, we identified @scriptdaemon, @pedrottimark and @kdex to be potential reviewers

[eslintbot]

LGTM

[ghost]

IIRC "always" is the default anyway, so the behavior should be equivalent to the previous version. But I do agree that being explicit about the parameters is a lot better in terms of documentation. Thank you! LGTM 👍

[chaintng]

setting just "always" alone break the API.
please see this issue airbnb/javascript#1088 (comment)

I think we need to make backward compatability also because it's minor release.

What do you think @kdex ?

[ghost]

@chaintng Hm, I've failed to reproduce this on ESLint 3.5.0 and 3.6.0 with the following file:

/* eslint eol-last: ["error"] */\n
var a = 2;

The output is as expected:

╰─$ ./bin/eslint.js check.js

/home/kdex/dev/eslint/check.js
  2:1   error  Use the global form of 'use strict'            strict
  2:1   error  Unexpected var, use let or const instead       no-var
  2:5   error  'a' is defined but never used                  no-unused-vars
  2:11  error  Newline required at end of file but not found  eol-last

✖ 4 problems (4 errors, 0 warnings)

If you have a consistent way of reproducing this error, could you please— in addition to this PR—open up an issue about it?

[eslintbot]

LGTM

[chaintng]

Ah, yes. i was misunderstanding.
But why Travis throw failed test 😕

i try npm test on master branch it also failed too 😕

[ghost]

Travis indeed failed for some node versions. The build and tests for Node 4.x were successful. Node 5.x and 6.x failed with:

ESLint couldn't find the plugin "eslint-plugin-node".

which seems like a problem on our end; don't worry about it. It has nothing to do with eol-last.

For more information on the failure, see #7239.

[vitorbal]

LGTM. Thanks, @chaintng!