Build: Do not strip .md extension from absolute URLs #7222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
kaicataldo
force-pushed
the
fixtemplatelinks
branch
2 times, most recently
from
0e37ae3
to
cfa2dcf
Compare
kaicataldo
changed the title
kaicataldo
force-pushed
the
fixtemplatelinks
branch
from
cfa2dcf
to
ea6ef31
Compare
kaicataldo
changed the title
kaicataldo
force-pushed
the
fixtemplatelinks
branch
from
ea6ef31
to
2a19148
Compare
kaicataldo
force-pushed
the
fixtemplatelinks
branch
from
2a19148
to
0535e9c
Compare
|
LGTM |
ilyavolodin
added
bug
This was referenced Oct 21, 2016
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
Fixes eslint/archive-website#288.
We currently strip the .md extension from all URLs, but we actually do want to send users to the template .md files on GitHub in this case.
Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
Updated the site generator to not strip
.mdfrom links that start withhttpandhttps.Is there anything you'd like reviewers to focus on?
Nope!