Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Steps for adding new committers/TSCers #7221

Merged
merged 1 commit into from Sep 30, 2016
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Sep 23, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • I've included tests for my change
  • I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

Listed the steps for adding a new committer or TSC member after they have been approved.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@nzakas nzakas added enhancement This change enhances an existing feature of ESLint documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion labels Sep 23, 2016
@eslintbot
Copy link

LGTM

1. Add the GitHub user to the "ESLint Team" team
2. Send welcome email with link to maintainer guide
3. Add committer email to the ESLint team mailing list
4. Tweet congratulations to the new committer from the ESLint Twitter account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if we want to mention updating the README as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to gitter room and README

2. Set the GitHub user to be have the "Owner" role for the ESLint organization
3. Send welcome email with link to maintainer guide
4. Make TSC member an admin on the ESLint team mailing list
5. Tweet congratulations to the new TSC member from the ESLint Twitter account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if we want to mention updating the README as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to gitter room, README, tweetdeck, jenkins (anything else?)

@eslintbot
Copy link

LGTM

@eslintbot
Copy link

LGTM

5. Invite to Gitter TSC chatroom
6. Make TSC member an admin on the ESLint team mailing list
7. Add TSC member as an admin to ESLint Twitter Account on Tweetdeck
8. Tweet congratulations to the new TSC member from the ESLint Twitter account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you forgot about tweetdeck permissions.

Also, add new member timezone to the next TSC meeting issue. I find it super useful (I always forget the exact time of the meeting :))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say to add them as an admin on tweetdeck, is there some other permission you're referring to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, sorry. I didn't see that line :/

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaicataldo kaicataldo merged commit 876d747 into master Sep 30, 2016
@alberto alberto deleted the maintainerdocs branch December 15, 2016 22:06
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation enhancement This change enhances an existing feature of ESLint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants