New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Steps for adding new committers/TSCers #7221
Conversation
LGTM |
1. Add the GitHub user to the "ESLint Team" team | ||
2. Send welcome email with link to maintainer guide | ||
3. Add committer email to the ESLint team mailing list | ||
4. Tweet congratulations to the new committer from the ESLint Twitter account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if we want to mention updating the README as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to gitter room and README
2. Set the GitHub user to be have the "Owner" role for the ESLint organization | ||
3. Send welcome email with link to maintainer guide | ||
4. Make TSC member an admin on the ESLint team mailing list | ||
5. Tweet congratulations to the new TSC member from the ESLint Twitter account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if we want to mention updating the README as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add to gitter room, README, tweetdeck, jenkins (anything else?)
5e7dc5b
to
9ea7956
Compare
LGTM |
9ea7956
to
dbcdd0d
Compare
LGTM |
5. Invite to Gitter TSC chatroom | ||
6. Make TSC member an admin on the ESLint team mailing list | ||
7. Add TSC member as an admin to ESLint Twitter Account on Tweetdeck | ||
8. Tweet congratulations to the new TSC member from the ESLint Twitter account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you forgot about tweetdeck permissions.
Also, add new member timezone to the next TSC meeting issue. I find it super useful (I always forget the exact time of the meeting :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say to add them as an admin on tweetdeck, is there some other permission you're referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, sorry. I didn't see that line :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
Listed the steps for adding a new committer or TSC member after they have been approved.
Is there anything you'd like reviewers to focus on?
Nothing in particular.