Update: add fixer for lines-around-directive
#7217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@not-an-aardvark, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kaicataldo to be a potential reviewer |
|
LGTM |
ilyavolodin
added
enhancement
|
I'll champion this. @eslint/eslint-team could use two more supporters! |
kaicataldo
approved these changes
Sep 26, 2016
ilyavolodin
added
accepted
platinumazure
approved these changes
Sep 29, 2016
|
LGTM. Thanks for contributing to ESLint! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[x] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
This adds a fixer for
lines-around-directive.If the rule reports a missing newline, the fixer adds the newline. If the rule reports an unexpected newline, the fixer removes the newline.
Is there anything you'd like reviewers to focus on?
Nothing in particular.