New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: add fixer for prefer-numeric-literals
#7205
Update: add fixer for prefer-numeric-literals
#7205
Conversation
@not-an-aardvark, thanks for your PR! By analyzing the annotation information on this pull request, we identified @azhang496 to be a potential reviewer |
LGTM |
Just one question about the very last invalid test-- it looks like an unquoted string is used for |
I think it's just a rendering issue -- it looks fine for me. (screenshot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ah, when I highlighted individual characters I eventually saw the quotes. Firefox rendering issue indeed, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
I'll champion this one-- just need one more endorsement to accept. |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[x] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Please check each item to ensure your pull request is ready:
What changes did you make? (Give an overview)
This adds a fixer for
prefer-numeric-literals
.When given a function call such as
parseInt('123', 16)
, the fixer replaces it with0x123
.parseInt
has some weird behavior; it accepts strings that look invalid. For example,parseInt('1 foo bar baz', 16)
returns1
. The fixer only performs a fix if the literal inparseInt()
would also be parseable as a regular number literal.Is there anything you'd like reviewers to focus on?
Nothing in particular.