Fix: prefer-const false negative about eslintUsed (fixes #5837)
#6971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mysticatea, thanks for your PR! By analyzing the annotation information on this pull request, we identified @NickHeiner, @vitorbal and @nzakas to be potential reviewers |
|
LGTM |
| @@ -82,7 +82,7 @@ function canBecomeVariableDeclaration(identifier) { | |||
| * Otherwise, null. | |||
| */ | |||
| function getIdentifierIfShouldBeConst(variable, ignoreReadBeforeAssign) { | |||
| if (variable.eslintUsed) { | |||
| if (variable.eslintUsed && variable.scope.type === "global") { | |||
There was a problem hiding this comment.
Can you add a comment in the JSDoc to explain why you're checking for global scope?
|
Lgtm, just one note about updating a comment to explain this change. |
|
LGTM |
1 similar comment
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5837.
This PR makes
prefer-constwarning used variables bycontext.markVariableAsUsed(name)API, on except global scope./*exported*/comments also are usingeslintUsed.I thought
prefer-constshould not warnfooin the following code.prefer-conststill ignore used global variables bycontext.markVariableAsUsed(name)API (since/*exported*/comment is applied to only global variables).But this PR will improve the issue.
In most cases, the variables that
react/jsx-use-varsmarks are on Node.js/CommonJS scope or Module scope.EDIT: This needs minor bump since this will increase warnings.