Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update options in object-shorthand #6898

Merged
merged 1 commit into from Aug 12, 2016
Merged

Docs: Update options in object-shorthand #6898

merged 1 commit into from Aug 12, 2016

Conversation

meeber
Copy link
Contributor

@meeber meeber commented Aug 12, 2016

What issue does this pull request address?

Minor documentation issue. The option values for the object-shorthand rule were listed twice, but when the new consistent and consistent-as-needed values were added only the second list was updated.

What changes did you make? (Give an overview)

Rather than update the first list with the new option values, I just got rid of it. It seemed unnecessary to have two lists given that the first list was right above the second list.

Is there anything you'd like reviewers to focus on?

Global warming

@mention-bot
Copy link

@meeber, thanks for your PR! By analyzing the annotation information on this pull request, we identified @pedrottimark, @martijndeh and @lemonmade to be potential reviewers

@eslintbot
Copy link

LGTM

@ilyavolodin
Copy link
Member

LGTM. Thanks for PR!

@ilyavolodin ilyavolodin merged commit 3fe3a4f into eslint:master Aug 12, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants