Build: Add CI release scripts (fxies #6884) #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @nzakas! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
|
LGTM |
|
LGTM, but waiting another day for others to look |
|
LGTM. |
|
These particular changes may not be necessary - let's hold off so I can verify. |
|
LGTM |
|
LGTM |
| @@ -650,7 +651,7 @@ target.gensite = function(prereleaseVersion) { | |||
| } | |||
| const added = versions.added[baseName]; | |||
|
|
|||
| if (!versions.removed[baseName] && !test("-f", sourcePath)) { | |||
| if (!versions.removed[baseName] && !fs.existsSync(sourcePath)) { | |||
There was a problem hiding this comment.
Slightly different logic here, right? Before it was checking if it exists and if it's a file, not it just checks if it exists.
There was a problem hiding this comment.
Oops, not sure how this got in. Removing.
|
LGTM |
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
#6884
What changes did you make? (Give an overview)
ci-releasescriptAddedgh-releasescriptIs there anything you'd like reviewers to focus on?
Ensure changes in
Makefile.jsmake sense.