Fix: no-dupe-keys false negative (fixes #6801)
#6863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a false negative between a normal property and a getter/setter. In addition, I upgrade code by ES2015.
|
@mysticatea, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vitorbal, @nzakas and @iancmyers to be potential reviewers |
|
LGTM |
| // Helpers | ||
| //------------------------------------------------------------------------------ | ||
|
|
||
| const GET_KIND = /^(?:init|get)$/; |
There was a problem hiding this comment.
Sorry, I'm not sure what the first part of this regEx is supposed to check?
There was a problem hiding this comment.
Normal property's kind is "init". This regexp is handling normal properties as getter/setter pair. As a result, this rule will address {a: 1, get a() {}} as duplicate keys. This is the purpose of this PR :)
There was a problem hiding this comment.
Ah, OK, now I understand, thanks.
|
Lgtm |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6801.
This PR fixes a false negative between a normal property and a getter/setter.
In addition, I upgrade code by ES2015.