Update: validate void operator in no-constant-condition (fixes #5726) #6837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vitorbal, thanks for your PR! By analyzing the annotation information on this pull request, we identified @pvamshi, @BYK and @pedrottimark to be potential reviewers |
|
LGTM |
|
LGTM, waiting for others to review. |
|
LGTM as well. I think this probably deserves another day's worth of review opportunities, though. |
|
LGTM, but waiting another day for others to look |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
#5726 Add check for the void operator to the
no-constant-conditionruleWhat changes did you make? (Give an overview)
I added the check for the rule, updated the rule description, and added a bunch of tests for all the cases I could think of.
Is there anything you'd like reviewers to focus on?
Are there any more test cases I could add?