Chore: use native Object.assign (refs #6407)
#6832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@gyandeeps Can you run perf test before and after for this change please? |
|
@ilyavolodin : when i made this change performance was not the motivation 馃槃 . but i guess there is no difference based on the numbers. BeforeLoading:
Load performance Run #1: 285.152035ms
Load performance Run #2: 293.246393ms
Load performance Run #3: 286.062485ms
Load performance Run #4: 288.535803ms
Load performance Run #5: 277.653648ms
Load Performance median: 286.062485ms
Single File:
CPU Speed is 2793 with multiplier 13000000
Performance Run #1: 3404.311078ms
Performance Run #2: 3374.370675ms
Performance Run #3: 3362.172693ms
Performance Run #4: 3387.370983ms
Performance Run #5: 3407.566561ms
Performance budget ok: 3387.370983ms (limit: 4654.493376297887ms)
Multi Files (0 files):
CPU Speed is 2793 with multiplier 39000000
Performance Run #1: 944.787268ms
Performance Run #2: 1000.370191ms
Performance Run #3: 1036.133591ms
Performance Run #4: 1156.578407ms
Performance Run #5: 1120.515556ms
Performance budget ok: 1036.133591ms (limit: 13963.480128893663ms)AfterLoading:
Load performance Run #1: 283.44549ms
Load performance Run #2: 281.234239ms
Load performance Run #3: 285.52076ms
Load performance Run #4: 290.018767ms
Load performance Run #5: 279.19379ms
Load Performance median: 283.44549ms
Single File:
CPU Speed is 2793 with multiplier 13000000
Performance Run #1: 3345.934495ms
Performance Run #2: 3364.047106ms
Performance Run #3: 3374.118139ms
Performance Run #4: 3369.067411ms
Performance Run #5: 3377.237274ms
Performance budget ok: 3369.067411ms (limit: 4654.493376297887ms)
Multi Files (0 files):
CPU Speed is 2793 with multiplier 39000000
Performance Run #1: 901.099578ms
Performance Run #2: 900.602568ms
Performance Run #3: 901.339652ms
Performance Run #4: 894.463259ms
Performance Run #5: 893.263986ms
Performance budget ok: 900.602568ms (limit: 13963.480128893663ms) |
|
LGTM, but waiting another day for others to look |
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
Use native function rather than a polyfill from
lodash. This way we are more native bound than library bound 馃槃What changes did you make? (Give an overview)
Replaced
lodash.assignwith nativeObject.assign. As a result of this i was able to get rid oflodashin many modules.Is there anything you'd like reviewers to focus on?
nothing specific