Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add link to rule change guidelines in "needs info" template #6831

Merged
merged 1 commit into from Aug 2, 2016

Conversation

platinumazure
Copy link
Member

What issue does this pull request address?
Fixes #6829.

What changes did you make? (Give an overview)
Added link to "Proposing a Rule Change" page. Also moved bug section to its own line to improve clarity.

Is there anything you'd like reviewers to focus on?
Nope.

@mention-bot
Copy link

@platinumazure, thanks for your PR! By analyzing the annotation information on this pull request, we identified @BYK and @nzakas to be potential reviewers

@eslintbot
Copy link

Thanks for the pull request, @platinumazure! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@vitorbal
Copy link
Member

vitorbal commented Aug 2, 2016

Nice! Lgtm.

@platinumazure platinumazure merged commit 579ec49 into master Aug 2, 2016
@platinumazure platinumazure deleted the eslintbot-rule-change branch August 2, 2016 19:26
eelyafi pushed a commit to eelyafi/eslint that referenced this pull request Aug 5, 2016
eelyafi pushed a commit to eelyafi/eslint that referenced this pull request Aug 5, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants