Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove incorrect "constructor" statemant from no-new-symbol docs #6830

Merged
merged 1 commit into from Aug 2, 2016

Conversation

jrencz
Copy link
Contributor

@jrencz jrencz commented Aug 2, 2016

What issue does this pull request address?
It refers to a comment in #6825

What changes did you make? (Give an overview)
I removed "constructor" word from the rule overview.

Is there anything you'd like reviewers to focus on?
n/a

@mention-bot
Copy link

@jrencz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @alberto, @aubergine10 and @scriptdaemon to be potential reviewers

@eslintbot
Copy link

Thanks for the pull request, @jrencz! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@jrencz jrencz force-pushed the no-new-symbol-no-constructor branch from c6adf5e to 7d7ddfa Compare August 2, 2016 18:39
@eslintbot
Copy link

LGTM

@jrencz jrencz changed the title Docs: Remove incorrect "Symbol constructor" statemant from no-new-symbol docs Docs: Remove incorrect "constructor" statemant from no-new-symbol docs Aug 2, 2016
@platinumazure
Copy link
Member

LGTM, just waiting for others to review.

@vitorbal
Copy link
Member

vitorbal commented Aug 2, 2016

Lgtm

@vitorbal vitorbal merged commit 117e7aa into eslint:master Aug 2, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants