Fix: no-invalid-this false positive (fixes #6824)
#6827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mysticatea, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kevinoid, @nzakas and @nre to be potential reviewers |
|
LGTM |
|
LGTM, but waiting for others to review. |
| @@ -11,12 +11,13 @@ Basically this rule checks whether or not a function which are containing `this` | |||
| This rule judges from following conditions whether or not the function is a constructor: | |||
|
|
|||
| * The name of the function starts with uppercase. | |||
| * The function is assigned to a variable the name starts with uppercase. | |||
There was a problem hiding this comment.
Small grammar improvement if you're interested: "The function is assigned to a variable which starts with an uppercase letter."
There was a problem hiding this comment.
Thank you for correction!
|
Just one or two small things, otherwise LGTM. Thanks for turning this around so quickly! |
|
LGTM, excluding existing comments. Nice work @mysticatea! |
|
LGTM |
|
I modified those. |
|
LGTM. Thanks @mysticatea! |
|
LGTM, thanks! |
|
LGTM 👍 |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6824.
This PR fixes the false positive of
no-invalid-thisrule. (reduces warnings)If an anonymous function is assigned to a variable that the name starts with uppercase, the rule comes to handle the function as a constructor (i.e.
thisin the function is valid.).This is similar to an existing behavior; a function that the name starts with uppercase is handled as a constructor.