Fix: ignore MemberExpression in VariableDeclarators (fixes #6795) #6815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chained properties on objects will typically not be indented as the rule expects in variable declarations. For now, ignore variable declarations (as was done in the previous version of ESLint, where all chained properties were ignored) and possibly revisit later to offer users opportunity to enforce alignment and/or sensible indentation.
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
#6795 (continues work from #6796)
What changes did you make? (Give an overview)
Just rebased.
Is there anything you'd like reviewers to focus on?
Nope. #6796 was already approved, this just eliminates the merge conflicts.