Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Updated no-control-regex tests to cover all cases (fixes #6438) #6752

Merged
merged 1 commit into from Jul 28, 2016
Merged

Chore: Updated no-control-regex tests to cover all cases (fixes #6438) #6752

merged 1 commit into from Jul 28, 2016

Commits on Jul 26, 2016

  1. Chore: Updated no-control-regex tests to cover all cases (fixes #6438) 

    toString prints out different outputs for /\x01/ and "/\x01/". Because
of that behavior, no-control-regex rule was broken before(fixed on 141b778).

During the fix I added a test to cover the case I wrote for fix. Which
was also passing when the fix was not there. The test was on a string
literal unfortunately which was not covering the test case where regex
is written on a literal (like /\x01/). Changed the tests to make sure it
covers the literal regex's as expected.
    @efegurkan
    efegurkan committed Jul 26, 2016
    Copy the full SHA
    4395613 View commit details
    Browse the repository at this point in the history