Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include period at end of no-unused-vars message #6739

Merged
merged 1 commit into from Jul 24, 2016
Merged

Include period at end of no-unused-vars message #6739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rules/no-unused-vars.js
View file
Open in desktop
Expand Up @@ -60,7 +60,7 @@ module.exports = {

create: function(context) {

var MESSAGE = "'{{name}}' is defined but never used";
var MESSAGE = "'{{name}}' is defined but never used.";

var config = {
vars: "all",
Expand Down
8 changes: 4 additions & 4 deletions tests/lib/cli-engine.js
View file
Open in desktop
Expand Up @@ -2010,7 +2010,7 @@ describe("CLIEngine", function() {

var report = engine.executeOnFiles([getFixturePath("processors", "test", "test-processor.txt")]);

assert.equal(report.results[0].messages[0].message, "'b' is defined but never used");
assert.equal(report.results[0].messages[0].message, "'b' is defined but never used.");
assert.equal(report.results[0].messages[0].ruleId, "post-processed");
});
it("should run processors when calling executeOnFiles with config file that specifies preloaded processor", function() {
Expand Down Expand Up @@ -2041,7 +2041,7 @@ describe("CLIEngine", function() {

var report = engine.executeOnFiles([getFixturePath("processors", "test", "test-processor.txt")]);

assert.equal(report.results[0].messages[0].message, "'b' is defined but never used");
assert.equal(report.results[0].messages[0].message, "'b' is defined but never used.");
assert.equal(report.results[0].messages[0].ruleId, "post-processed");
});
it("should run processors when calling executeOnText with config file that specifies a processor", function() {
Expand All @@ -2054,7 +2054,7 @@ describe("CLIEngine", function() {

var report = engine.executeOnText("function a() {console.log(\"Test\");}", "tests/fixtures/processors/test/test-processor.txt");

assert.equal(report.results[0].messages[0].message, "'b' is defined but never used");
assert.equal(report.results[0].messages[0].message, "'b' is defined but never used.");
assert.equal(report.results[0].messages[0].ruleId, "post-processed");
});
it("should run processors when calling executeOnText with config file that specifies preloaded processor", function() {
Expand Down Expand Up @@ -2085,7 +2085,7 @@ describe("CLIEngine", function() {

var report = engine.executeOnText("function a() {console.log(\"Test\");}", "tests/fixtures/processors/test/test-processor.txt");

assert.equal(report.results[0].messages[0].message, "'b' is defined but never used");
assert.equal(report.results[0].messages[0].message, "'b' is defined but never used.");
assert.equal(report.results[0].messages[0].ruleId, "post-processed");
});
});
Expand Down