Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: combine multiple RegEx replaces with one #6661

Merged
merged 1 commit into from Jul 15, 2016
Merged

chore: combine multiple RegEx replaces with one #6661

merged 1 commit into from Jul 15, 2016

Conversation

thefourtheye
Copy link
Contributor

What issue does this pull request address?

Performance improvement

What changes did you make? (Give an overview)

Combining two subsequent RegEx replaces with one replace.

Is there anything you'd like reviewers to focus on?

Yes, the RegEx.

@eslintbot
Copy link

Thanks for the pull request, @thefourtheye! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@thefourtheye
Copy link
Contributor Author

Okay. Signed the CLA now.

@ilyavolodin
Copy link
Member

@thefourtheye Chore PRs require an open issue. Would you mind opening a new issue for this.

@thefourtheye
Copy link
Contributor Author

@ilyavolodin Sure. PTAL at #6669

@ilyavolodin
Copy link
Member

LGTM, but waiting another day for others to look

@ilyavolodin ilyavolodin merged commit 421e4bf into eslint:master Jul 15, 2016
@thefourtheye thefourtheye deleted the chore-regex-improvement branch July 15, 2016 03:19
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants