Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use default assertion messages for rule tester messages #6615

Merged
merged 1 commit into from Jul 8, 2016

Conversation

aaronabramov
Copy link
Contributor

Fixes #6532

@eslintbot
Copy link

Thanks for the pull request, @DmitriiAbramov! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary must be 72 characters or shorter. Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@eslintbot
Copy link

LGTM

@ilyavolodin
Copy link
Member

I wonder if we want to do the same for everything (type, line, column, etc.)

@platinumazure
Copy link
Member

Hmm. This might just need a force-push to restart the Travis build.

I agree with @ilyavolodin about removing messages from all assertions, if feasible.

@aaronabramov
Copy link
Contributor Author

yeah. i'll update the PR

@nzakas
Copy link
Member

nzakas commented Jul 8, 2016

Let's not expand the scope of this PR further than it was originally intended.

@ilyavolodin if you want to propose other changes, please open a separate issue as I have concerns about removing the message for other assertions.

@ilyavolodin
Copy link
Member

@nzakas Ok, sounds good. Should we merge this in as is than?

@nzakas
Copy link
Member

nzakas commented Jul 8, 2016

Yeah. I just realized the Travis failure was the Node 6 thing we already fixed. LGTM.

@nzakas nzakas merged commit ca323cf into eslint:master Jul 8, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants