New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Distinguish examples in rules under Stylistic Issues part 6 #6567
Docs: Distinguish examples in rules under Stylistic Issues part 6 #6567
Conversation
By analyzing the blame information on this pull request, we identified @mysticatea, @pedrottimark and @cjihrig to be potential reviewers |
LGTM |
|
||
## Rule Details | ||
|
||
The following patterns are considered problems: | ||
This rule disallow trailing whitespace at the end of lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/disallow/disallows/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about deleting the comment in incorrect code below and adding it here?
This rule disallows trailing whitespace (spaces, tabs, and other Unicode whitespace characters) at the end of lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry for making the second suggestion in an ambiguous way. We ended up with two similar sentences in the paragraph.
@scriptdaemon Thank you. Nice work. 5 rules was a good amount for now. In
|
} | ||
} = obj; | ||
``` | ||
|
||
### separating configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative to consider for this heading is ObjectExpression and ObjectPattern
d7bfb96
to
8207a29
Compare
LGTM |
@pedrottimark Thank you. Yeah, I figured 5 was better than none. The examples for combined multiline and minProperties did seem redundant to me, so that is why I removed them. |
Only one more change in |
8207a29
to
d193f8d
Compare
LGTM |
@pedrottimark Fixed. Probably should have paid more attention when making the latest updates. 馃槃 |
Looks good to me |
Found some time to get a quick batch in.
object-curly-newline
has the option to have separate configurations for object literals and destructuring assignments. My mind is drawing a blank, did we have any specific way to handle options for this kind of case?@pedrottimark Mind giving this a look?
Slowly and surely... 馃槂