New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: false negative of max-len
(fixes #6564)
#6565
Conversation
By analyzing the blame information on this pull request, we identified @vitorbal, @kaicataldo and @bgw to be potential reviewers |
LGTM |
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
48ddb51
to
3289aa9
Compare
LGTM |
I think I've signed the CLA correctly; I'm not sure why jquerybot still has the |
The CLA check details says something about name "not-an-aardvark" needing manual verification. I'm not sure what that means. To be honest, this PR won't be merged until the issue is deliberated upon and accepted (hopefully it will take very little time to deliberate), so I think we might as well let that take its course. Whichever ESLint team member accepts the issue will also see the PR and become aware of the CLA issue. Unfortunately I don't know how to actually remedy CLA issues, I just read the check status pages. 😄 |
@not-an-aardvark I just took a spin through the repo which I think powers the license check bot, jquery/jquery-license. Found this validation file, which seems to have a heuristic where a username is split by spaces and if there's only one name, then that message is emitted. I don't know if "manual verification" means someone on the jQuery team can let this through. But what you can definitely do for sure is sign the CLA under your own name (unless you have one name, I guess) and then configure your local Git to sign commits with that name. Briefly:
Hope this helps. |
3289aa9
to
d1df71f
Compare
LGTM |
@kborchers Would you mind helping us with CLA again? |
d1df71f
to
5edd14f
Compare
LGTM |
Fixes #6564.
This corrects a bug in the
isFullLineComment
helper function, which was incorrectly identifying non-commented lines of code as full-line comments if they were preceded by a commented line of the same length.