Update: Implement IndentOuterIIFE option for indent rule (fixes #6259)

[davidshepherd7]

Partly fixes #6259. I've only added support for IIFEs and not for the other forms of full-file closures described here because I don't know much about the other forms.

Some questions for people who know a bit more about eslint:

• Do I need to add anything to the indent-valid-fixture-1.js or indent-invalid-fixture-1.js test files?
• Any thoughts on the option name?
• There are some crazy ways of writing IIFEs, should we support them all?

[eslintbot]

Thanks for the pull request, @davidshepherd7! I took a look to make sure it's ready for merging and found some changes are needed:

• The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
• Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[eslintbot]

Thanks for the pull request, @davidshepherd7! I took a look to make sure it's ready for merging and found some changes are needed:

• Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[eslintbot]

LGTM

[platinumazure]

Hi @davidshepherd7, thanks for the pull request!

For this change, the commit summary prefix should be "Update:" (we only use "New:" for completely new functionality and we consider a new option in an existing feature an enhancement). Thanks!

[eslintbot]

LGTM

[nzakas]

We probably need something different here. The other options are all node types, and this is not. Also, we are really talking about indenting the IIFE body, not the IIFE itself, so we need to work on this naming a bit.

[eslintbot]

LGTM

[nzakas]

@davidshepherd7 can you add some invalid tests, too?

[eslintbot]

LGTM

[davidshepherd7]

Ok I've added some invalid tests (and also renamed a function of mine that was inconsistent and rebased onto the current master).

[ilyavolodin]

LGTM

[nzakas]

Lgtm. Thanks @davidshepherd7 for your patience.