Docs: Describe options in rule under Strict Mode #6312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
pedrottimark
force-pushed
the
docs-strict-mode
branch
from
fe98f41
to
6198c9f
Compare
|
LGTM |
|
|
||
| A strict mode directive at the beginning of a script or function body enables strict mode semantics. | ||
| A strict mode directive is a `"use strict"` literal string expression at the beginning of a script or function body. It enables strict mode semantics. |
There was a problem hiding this comment.
You can omit "string expression" in this description.
pedrottimark
force-pushed
the
docs-strict-mode
branch
from
6198c9f
to
5507896
Compare
|
LGTM |
1 similar comment
|
LGTM |
pedrottimark
force-pushed
the
docs-strict-mode
branch
from
5507896
to
510c268
Compare
|
|
||
| All strict mode directives are flagged as unnecessary if ECMAScript modules or implied strict mode are enabled (see [Specifying Parser Options](../user-guide/configuring#specifying-parser-options)). This behaviour does not depend on the rule options, but can be silenced by disabling this rule. | ||
| * `"safe"` (default) corresponds either of the following options: | ||
| * `"global"` if ESLint considers a file to be a **Node.js** or **CommonJS** module |
There was a problem hiding this comment.
We probably just want to say "CommonJS" because Node.js will support ES modules within the next year
|
LGTM |
pedrottimark
force-pushed
the
docs-strict-mode
branch
from
510c268
to
f886656
Compare
|
Lgtm |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only rule under Strict Mode
Additional changes:
"never"option to be the last active option, so it does not separate"global"and"function"from"safe"Hint: The diff gets confusing after safe. At that point, you might click View and compare the markdown view to the Web site: http://eslint.org/docs/rules/strict