Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Remove commit check from appveyor (fixes #6292) #6294

Merged
merged 1 commit into from Jun 1, 2016
Merged

Conversation

alberto
Copy link
Member

@alberto alberto commented May 31, 2016

No description provided.

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @IanVS, @nzakas and @gyandeeps to be potential reviewers

@eslintbot
Copy link

LGTM

@IanVS
Copy link
Member

IanVS commented May 31, 2016

👍

@IanVS
Copy link
Member

IanVS commented May 31, 2016

Actually, shouldn't it also be removed from package.json and makefile.js? It's essentially dead code at this point, isn't it?

@alberto
Copy link
Member Author

alberto commented May 31, 2016

Mmm, now that you mention it... @nzakas did you actually intend to remove all git checks or just the number of commits in #6263? check-commit also validates the commit message format and length.

@nzakas
Copy link
Member

nzakas commented May 31, 2016

The bot already does the other checks, so we don't need Travis/Appveyor doing it as well.

I left the task in Makefile.js because I was unsure if developers were using it locally (it is mentioned in the pull request docs).

@platinumazure
Copy link
Member

@nzakas I sometimes use it locally. That said, I think we can leave it in Makefile.js without actually invoking it in npm test or in Travis/AppVeyor.

@alberto
Copy link
Member Author

alberto commented May 31, 2016

Ok, makes sense. PR is good as is, then.

@nzakas nzakas merged commit c78c8cb into master Jun 1, 2016
@alberto alberto deleted the issue6292 branch June 1, 2016 18:59
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants