New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Distinguish examples in rules under Stylistic Issues part 5 #6291
Docs: Distinguish examples in rules under Stylistic Issues part 5 #6291
Conversation
LGTM |
By analyzing the blame information on this pull request, we identified @alberto, @IanVS and @pedrottimark to be potential reviewers |
|
||
var foo = 5; | ||
|
||
|
||
|
||
var bar = 3; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these lines at the end confused me when I first read about this rule.
@scriptdaemon Thank you so much for working steadily through the second half of rules! |
f0e3139
to
e4fad2c
Compare
LGTM |
@pedrottimark Everything (except one concern that we should discuss) has been addressed up until this point. |
|
||
Nesting ternary expressions makes code unclear. The `no-nested-ternary` rule disallows the use of nested ternary expressions. | ||
Nesting ternary expressions can makes code more difficult to understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/can makes/can make/
From the “View the whole file” step: 2 changes for grammatical agreement and 1 phrase deletion |
e4fad2c
to
4d81d8e
Compare
LGTM |
@pedrottimark Done. Thanks for being patient with my numerous oversights. 😀 |
@scriptdaemon Thank you! It’s going well from my point of view 😀 Until we will write up a doc about docs, here is a principle to explain some of my comments:
In some rule docs, introduction leans forward into how and Rule Details leans backward into why. Here are two items in my mental check list:
|
Another straight-forward batch.
@pedrottimark Let me know if anything catches your eye.