New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: no-useless-rename
false positive in babel-eslint (fixes #6266)
#6290
Conversation
LGTM |
By analyzing the blame information on this pull request, we identified @kaicataldo to be a potential reviewer |
How does performance look, out of curiosity? |
@@ -109,7 +115,7 @@ module.exports = { | |||
} | |||
|
|||
if (node.imported.name === node.local.name && | |||
node.imported !== node.local) { | |||
!lodash.isEqual(node.imported, node.local)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you just check that range[0]
isn't the same? We really only care about the location, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would be better, thanks!
LGTM |
LGTM |
Lgtm |
Sorry, thought this was my branch - restored it! |
Sorry, this one should fix it for real. I manually tested it using
babel-eslint
.