Update: callback-return allows for object methods (fixes #4711) #6277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
By analyzing the blame information on this pull request, we identified @vitorbal, @nzakas and @gyandeeps to be potential reviewers |
| @@ -73,7 +74,7 @@ ruleTester.run("callback-return", rule, { | |||
|
|
|||
| // options (only warns with the correct callback name) | |||
| { | |||
| code: "if (err) { callback(err) }", | |||
There was a problem hiding this comment.
This was actually allowing anything to pass because it wasn't wrapped in a function
|
Can you update the docs to show methods will work? |
kaicataldo
force-pushed
the
fixes4711
branch
5 times, most recently
from
5c1d49b
to
b699c1e
Compare
|
|
||
| Examples of **incorrect** code for this rule with the default `["callback", "cb", "next"]` option: | ||
|
|
||
| ```js | ||
| /*eslint callback-return: "error"*/ | ||
|
|
||
| function foo() { | ||
| function foo(err, callback) { |
There was a problem hiding this comment.
For consistency with the example at the beginning. I think it makes the examples a little more concrete - please let me know if you disagree.
|
Updated |
|
LGTM |
|
Lgtm |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one caveat about solving this problem this way is that it must match exactly - i.e.Updated, no longer relevant.object().methodis not the same thing asobject.method. This seems to me like a reasonable tradeoff to solve this issue right now, though maybe it could be made much smarter in the future.