Fix: one-var allows uninitialized vars in ForIn/ForOf (fixes #5744) #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
By analyzing the blame information on this pull request, we identified @IanVS, @gyandeeps and @vitorbal to be potential reviewers |
| @@ -400,14 +450,6 @@ ruleTester.run("one-var", rule, { | |||
| }, | |||
| { | |||
| code: "var i = [0], j;", | |||
| options: [ { initialized: "never" } ], | |||
There was a problem hiding this comment.
Looks like this is a duplicate test
|
LGTM |
|
Code looks good. Can you add something to the docs? |
|
Oh yeah - sure thing! |
kaicataldo
force-pushed
the
fixes5744
branch
6 times, most recently
from
142bac8
to
f02e9bc
Compare
kaicataldo
changed the title
|
LGTM |
|
Updated with changes to the docs |
| @@ -203,6 +203,8 @@ function foo() { | |||
|
|
|||
| When configured with an object as the first option, you can individually control how `var`, `let`, and `const` are handled, or alternatively how `uninitialized` and `initialized` variables are handled (which if used will override `var`, `let`, and `const`). | |||
|
|
|||
| **Note:** A variable declared in a for-in or for-of loop will NOT be flagged with the option `{ uninitialized: "always" }`, as this value is determined by the loop. | |||
There was a problem hiding this comment.
Can you change "NOT" to lowercase (we don't do this anywhere else)?
|
LGTM |
|
Lgtm |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.