Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Describe options in rules under Possible Errors part 4 #6270

Merged
merged 1 commit into from May 31, 2016

Conversation

pedrottimark
Copy link
Member

@pedrottimark pedrottimark commented May 28, 2016

The last rule under Possible Errors

  • Make description in h1 consistent with rules index page, not even the first word is capitalized. That is because will soon change the format to match the rules index page (that is, rule-id: rule description).
  • Make first sentence under Rule Details consistent with description.
  • Add “this rule with” to example sentences.
  • Describe options according to patterns in guidelines.

Hint: The diff gets confusing after the bulleted list under Rule Details. At that point, you might click View and compare the markdown view to the Web site: http://eslint.org/docs/rules/valid-jsdoc

@nzakas EDIT can you verify that the rule details are clear, options list is correct, and examples are relevant, because I am just now learning JSDoc
@scriptdaemon your thoughts are welcome, especially on stretching the guidelines, as follows:

So far in new pattern, we describe options in bulleted lists and remove any redundant paragraphs between a level-3 heading for an option and the example code. I am open to your thoughts about including a paragraph of additional info following some of the option headings in this rule doc:

  • because this doc has such long scrolling distance from the descriptions to the examples
  • because there is some useful information that I cut because it did not fit into the bulleted list

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @nzakas, @gyandeeps and @IanVS to be potential reviewers

@scriptdaemon
Copy link
Contributor

I think it would be okay to allow an optional paragraph under option headers when there's important information that won't fit in the list.

Would you agree that adding require-jsdoc as a related rule would be a good idea (this one is already listed as a related rule on the require-jsdoc doc)?


With this configuration, ESLint will warn when it finds `@return` and recommend to replace it with `@returns`.
* `"prefer"` enforces consistent documentation tags specified by an object whose properties mean **disallow** the key and **allow** the value (for example, `"return": "returns"` means disallow `@return` and allow `@returns`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd describe this option as "instead of key use value"

@eslintbot
Copy link

LGTM

@nzakas
Copy link
Member

nzakas commented May 31, 2016

Lgtm

@nzakas nzakas merged commit 320e8b0 into master May 31, 2016
@pedrottimark pedrottimark deleted the docs-possible-errors-4 branch May 31, 2016 18:33
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants