New: object-curly-newline (fixes #6072)

[mysticatea]

Fixes #6072 (and #6205).

The issue has not been accepted yet, but I made this PR for a reference.
I'd like to see feedback, then if it can do, I'd like to add accepted label.

[eslintbot]

LGTM

[mention-bot]

By analyzing the blame information on this pull request, we identified @nzakas, @scriptdaemon and @pedrottimark to be potential reviewers

[eslintbot]

LGTM

[nzakas]

Can you add a section for compatibility?

Compatibility

• JSCS: rule name

[nzakas]

Note for all: this is equivalent to the JSCS rule http://jscs.info/rule/requirePaddingNewLinesInObjects

[eslintbot]

LGTM

[mysticatea]

Ugh, now I'm aware that object-curly-spacing is covering ES2015 Modules: https://github.com/eslint/eslint/blob/master/lib/rules/object-curly-spacing.js#L270

So... this rule should check it.

[nzakas]

Does this make sense for imports or exports? Maybe we should leave it out unless people ask for it?

[eslintbot]

LGTM

[mysticatea]

Hm, my reason is only consistency, so leaving it out is OK to me. Original JSCS rule doesn't handle imports and exports.
I just updated option names in order to match to #3763 proposal.

[nzakas]

Combinated -> combined

[mysticatea]

Thank you. I fixed it.

[eslintbot]

LGTM

[nzakas]

Lgtm

[onemen]

Why don't you check the file linebreak style before you add '\n' in the fixer
(in my test case my file uses \r\n)

fix: function(fixer) {
  return fixer.insertTextAfter(openBrace, "\n");
}

fix: function(fixer) {
  return fixer.insertTextBefore(closeBrace, "\n");
}

[ilyavolodin]

@onemen If you have linebreak-style rule enable, no matter what type of linebreak we will add in this rule, linebreak-style will fix it in a second pass to the one you specified.

[onemen]

I know that.
I disabled linebreak-style rule since it doesn't work with interactive-linter extension in Brackets editor

[mysticatea]

@onemen Not only linebreak-style. This autofix may make new warnings of indent, comma-dangle, comma-spacing, object-curly-spacing, and linebreak-style. Then those warnings would be addressed in a next pass. This is a design of autofix. If this rule needs to address also those warnings, this rule would become something like God Object.