New: no-restricted-properties rule (fixes #3218)

[willklein]

Fixes #3218.

Let me know if there's anything to address. Thanks!

[mention-bot]

By analyzing the blame information on this pull request, we identified @nzakas, @scriptdaemon and @alberto to be potential reviewers

[eslintbot]

LGTM

[nzakas]

Can you give an example here to make this concrete? Like, location.href for example? (or something better?)

[nzakas]

Overall looks good, just a few comments.

[pedrottimark]

disallow the use of specified object properties

After recent editing, most (but not quite all) occurrences of use are preceded by the.
Extra word :( but helps make clear it is a noun not a verb, especially if English is not first language of reader :)

[willklein]

I like it, great input. I'll update this.

[pedrottimark]

@willklein Thank you for investing the time and effort to research and follow existing precedents for the rule doc. Most of the line comments represent improvements we are in the middle of making, so by your extra effort right now, you level up with a rising tide, and save rework in the coming weeks. Thanks :)

[pedrottimark]

@nzakas Good question about options. Although we are moving away from separate examples of json config, this is parallel with no-restricted-syntax, so let’s say it’s good to go for this PR.

As we edit rules with simpler options schema, we gain experience for the more complex schema.

[pedrottimark]

Another thing that came to mind is reference to properties by object destructuring:

• Simplest solution is make it clear enough under Rule Details that it is member expressions which are disallowed, so object destructuring becomes a mute point (pardon the pun :)
• Alternative solution is a sentence under Rule Details like This rule does not apply to …

[nzakas]

@willklein just checking in to see if you're still working on this?

[nzakas]

@willklein when you get a chance, can you sign our new CLA? http://contribute.jquery.org/cla

[willklein]

@nzakas, yes and yes.

[ilyavolodin]

@willklein just checking to see if you are planning on finishing this up.

[originalfoo]

This might be the wrong time to bring this up, but could the option syntax be simplified like so:

// ...
  "no-restricted-properties": [ "error", [ {
    "objectName": {
      "propertyName1": "Error message 1",
      "propertyName2": "Error message 2"
    },
    "anotherObjectName": {
       // ...
    }, // etc
  } ] ],

[nzakas]

Please add that feedback to the issue.

[originalfoo]

@nzakas #5872 or #3218?

[nzakas]

@aubergine10 #3218

[nzakas]

@willklein last ping, I promise. :) If you aren't able to finish this up, can you just sign the jQuery CLA? That way, someone can continue your work and finish it up.

[nzakas]

Unfortunately, no response and without the CLA signed, we can't use the code. @willklein feel free to reopen if you'd like to continue.

[willklein]

Sorry all, @nzakas. I signed the jQuery CLA so my code can be picked up. I had a baby, then started a new job, so this year has been crazy for me. Making open source a part of what we do @Crownpeak but I'm focused on building the Denver team instead of coding right now.

[alberto]

Thanks, @willklein, we understand, life happens :). @nzakas the bot didn't pick it. Maybe it is because the issue is closed? Is there any way we can confirm the CLA signature is ok?