fix: references of Object.assign in prefer-object-spread

[Tanujkanti4441]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What rule do you want to change?
prefer-object-spread

What change do you want to make (place an "X" next to just one item)?

[ ] Generate more warnings
[x] Generate fewer warnings
[ ] Implement autofix
[ ] Implement suggestions

How will the change be implemented (place an "X" next to just one item)?

[ ] A new option
[ ] A new default behavior
[x] Other

Please provide some example code that this change will affect:

/*eslint prefer-object-spread: "error" */

var doSomething;

if (foo) {
    doSomething = Object.assign;
} else {
    doSomething = somethingElse;
}

var bar = doSomething({}, a, b); 

What does the rule currently do for this code?
Rule reports and fixes the doSomething({}, a, b) as it's a reference of Object.assign

What will the rule do after it's changed?
Rule will not report doSomething({}, a, b) and only report the Object.assign({}, a) and GlobalThis.Object.assign({}, a)

Is there anything you'd like reviewers to focus on?

Fixes #12826

[netlify]

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	6643f61
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/665de1bc77bce30008037a9e
😎 Deploy Preview	https://deploy-preview-18148--docs-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[snitin315]

I feel this should be reported because foo has never been reassigned.

Incorrect

/*eslint prefer-object-spread: "error" */

let doSomething;

doSomething = Object.assign;

var bar = doSomething({}, a, b); // Error

Correct

/*eslint prefer-object-spread: "error" */

let doSomething;

if (foo) {

doSomething = Object.assign;
} else {
doSomething = somethingElse
}
var bar = doSomething({}, a, b); // OK

[Tanujkanti4441]

seems like i have understood the issue wrong but what about autofixes is it also correct

/*eslint prefer-object-spread: "error" */

let doSomething;

doSomething = Object.assign;

var bar = { ...a, ...b}; 

[snitin315]

Yes, I believe the auto fix is also correct, doSomething will be reported by the no-unused-vars rule.

@mdjermanovic Can you once confirm the expected behavior?

[mdjermanovic]

The problem is that ReferenceTracker returns both certain references (e.g., const x = Object.assign; x();) and potential references (those that are references only in some code paths, e.g., const x = foo ? Object.assign : bar; x();), which is okay for some rules (e.g., for no-obj-calls, because it's a bug if JSON() is called in any code paths) but not for this one.

We currently don't have a utility that would help find only certain references. The solution could be:

1. Add an option to ReferenceTracker to not return potential references.
2. Make another utility.
3. Limit this rule to check only explicit Object.assign calls. Maybe also <global object>.Object.assign (like no-eval).

[Tanujkanti4441]

So, changes in this PR falls in 3rd point so what should we do now, move forward or look for another approaches (point 1st and 2nd)?
the reason i chose 3rd one is i noticed in this rule's previous version is that references was used so that it allows the Object.assign if Object is importing from a module, and i didn't find any tests which doesn't call Object.assign directly.

[Tanujkanti4441]

I am still doubtful that this fix is correct and doesn't lead to bugs.

/*eslint prefer-object-spread: "error" */

let doSomething;

doSomething = Object.assign;

var bar = { ...a, ...b}; 

[mdjermanovic]

Perhaps we could first ask at https://github.com/eslint-community/eslint-utils if option 1 would be possible. If not, then I think option 3 is fine.

[aladdin-add]

ci failing has been fixed in the main branch, can you please rebase it, thanks!

[linux-foundation-easycla]

• ✅ login: kirkwaiblinger / name: Kirk Waiblinger (1579ce0, 610c148, b8fb572, db0b174)
• ✅ login: JoshuaKGoldberg / name: Josh Goldberg ✨ (1765c24, 8485d76, 778082d)
• ✅ login: mdjermanovic / name: Milos Djermanovic (9048e21, d73a33c, e80b60c, 96607d0, 4820790, 698d9ff, 651ec91, 32c08cf, a76fb55, 7509276, 347d44f, b346605, 26384d3, dadc5bf, 37eba48, 925afa2, 79a95eb, f6534d1, 09675e1, 70118a5, a63ed72, d16a659, 73408de)
• ✅ login: snitin315 / name: Nitin Kumar (972ef15, e37153f, d7ab6f5, 89a4a0a)
• ✅ login: fasttime / name: Francesco Trotta (a451b32, ae8103d, 1f1260e, 200fd4e, f316e20, ceada8c, a498f35, 1fa6622, e1e305d, a98babc, 297416d, 751b518, d9a2983, 450d0f0, 594145f, 58e2719, af6e170, 594eb0e, 069aa68, 010dd2e, b91f9dc)
• ✅ login: cuithon (29c3595)
• ✅ login: nzakas / name: Nicholas C. Zakas (d54a412, 27e3060, a129acb, 2908b9b, 3e9fcea, c7abd89, 113f51e, 7747097, 0588fc5, 19f9a89, 0d8cf63, e1ac0b5, 337cdf9, 03068f1, 8d18958, 09bd7fe, 8db0eff, 62e686c)
• ✅ login: aladdin-add / name: 唯然 (e151050, 4d11e56, 0db676f, f12a02c, a26b402, 78e45b1, eeec413, c537d76, 36103a5, 05ef92d, 389744b, 2c8fd34)
• ✅ login: DMartens / name: fnx (e508800)
• ✅ login: lo1tuma / name: Mathias Schreck (c49ed63)
• ✅ login: germanfrelo / name: Germán Freixinós (71c771f)
• ✅ login: Pearce-Ropion / name: Pearce Ropion (97ce45b)
• ✅ login: adamlui / name: Adam Lui 刘展鹏 (5c35321)
• ✅ login: eMerzh / name: eMerzh (b7cf3bd)
• ✅ login: Tanujkanti4441 / name: Tanuj Kanti (12f5746, df5f8a9, b93f408, 769f997, 4769c86, d85c436, 04e7c6e, 1cbe1f6, 1c173dc, e5ef3cd, 525fdff, e49202d, 6643f61, 80747d2)
• ✅ login: MichielPater / name: M Pater (11144a2)
• ✅ login: renovate[bot] (9b7bd3b, f47847c, c18ad25, 040700a, 06f1d1c)
• ✅ login: avoidaway (1b841bb)
• ✅ login: pwbriggs / name: Peter Briggs (ac7f718)
• ✅ login: gavvvr / name: Kirill Gavrilov (b07d427)
• ✅ login: MikeMcC399 / name: Mike McCready (0de0909)
• ✅ login: webpro / name: Lars Kappert (44a81c6, acc2e06)
• ✅ login: antfu / name: Anthony Fu (94178ad)
• ✅ login: MaoShizhong (e763512)
• ✅ login: gwBear1 / name: gyeongwoo park (239a7e2)
• ✅ login: ota-meshi / name: Yosuke Ota (d961eeb)
• ✅ login: Grohden / name: Gabriel Rohden (fb50077)
• ✅ login: friederbluemle / name: Frieder Bluemle (1db9bae)
• ✅ login: rzvxa / name: Ali Rezvani (7226ebd)
• ✅ login: camsteffen / name: Cameron Steffen (f06e0b5)
• ✅ login: akulsr0 / name: Akul Srivastava (b67eba4)
• ✅ login: KubaJastrz / name: Kuba Jastrzębski (5c28d9a)
• ✅ login: shulaoda / name: dalaoshu (39fb0ee)
• ✅ login: mnkiefer / name: Mara Nikola Kiefer (de40874)
• ✅ login: benj-dobs (d23574c)
• ✅ login: kecrily / name: Percy Ma (b32153c)
• ❌ The email address for the commit (ef36aa4, b4d2512, 41a871c, 463a2e3, b681ecb, 989ac9d, 950c4f1, 16b6a8b, 284722c, e17e1c0, c4c18e0, 2465a1e, d7ec0d1, e0cbc50, 75cb5f4, ba89c73, 271e7ab, 0f5df50, 7065196, 1dc8618, 7c957f2, b185eb9, b78d831, 26010c2, e4d9c92, d363c51, 558274a, 50d406d, 155c71c, ba1c1bb, 96087b3, 5251327, 5e1b5dc, 8c6d0c3, a5f7e58) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

[Tanujkanti4441]

Sorry! i just tried something and this happened, i'll open a new one.