New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: Upgrade lodash dependency (fixes #11992) #11994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
An ESLint team member will look at this issue soon
label
Jul 15, 2019
quetzaluz
force-pushed
the
upgrade-lodash-fix-11992
branch
2 times, most recently
from
July 15, 2019 23:11
bb3a140
to
758f99e
Compare
quetzaluz
changed the title
Fix #11992 - Upgrade lodash dependency per lodash/lodash#4348
Chore: Upgrade lodash dependency lodash/lodash#4348 (fixes #11992)
Jul 15, 2019
Issue in lodash filed at lodash/lodash#4348
quetzaluz
force-pushed
the
upgrade-lodash-fix-11992
branch
from
July 15, 2019 23:13
758f99e
to
bc30c2d
Compare
quetzaluz
changed the title
Chore: Upgrade lodash dependency lodash/lodash#4348 (fixes #11992)
Upgrade: Upgrade lodash dependency (fixes #11992)
Jul 15, 2019
g-plane
added
chore
This change is not user-facing
and removed
triage
An ESLint team member will look at this issue soon
labels
Jul 16, 2019
g-plane
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks @quetzaluz for the fix #11992. Any idea, when this change will be available to master? |
platinumazure
approved these changes
Jul 16, 2019
aladdin-add
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This was referenced Aug 27, 2019
This was referenced Sep 12, 2019
This was referenced Nov 9, 2019
eslint-deprecated
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Jan 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
archived due to age
This issue has been archived; please open a new issue for any further discussion
chore
This change is not user-facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?