Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: --rulesdir option didn't work (fixes #11888) #11890

Merged
merged 1 commit into from Jun 25, 2019
Merged

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #11888

What changes did you make? (Give an overview)

This PR fixes a bug that CLEngine ignored baseConfig and rulePaths if a config file has root:true.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion patch candidate This issue may necessitate a patch release in the next few days labels Jun 24, 2019
@aladdin-add
Copy link
Member

the build failing somehow, but seems not related to this change.

@mysticatea
Copy link
Member Author

Some cloud services look bad condition currently (I have seen Netlify timed out on other repos).

@not-an-aardvark not-an-aardvark merged commit b5bde06 into master Jun 25, 2019
@not-an-aardvark not-an-aardvark deleted the issue11888 branch June 25, 2019 01:03
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 23, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features patch candidate This issue may necessitate a patch release in the next few days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[6.0.0] '--rulesdir' option doesn't work if a config file has 'root:true'
6 participants