Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CLIEngine#getRules() contains plugin rules (fixes #11871) #11872

Merged
merged 1 commit into from Jun 23, 2019

Conversation

mysticatea
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[X] Bug fix: #11871

What changes did you make? (Give an overview)

This PR fixes CLIEngine as the following code contains plugin rules.

new CLIEngine({ plugins: ['foo'] }).getRules()

Previously, CLIEngine#getRules() contains core rules and the plugin rules that the last CLIEngine#executeOn*() methods call used.

This PR changes only the behavior that is before CLIEngine#executeOn*() methods called.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

@mysticatea mysticatea added bug ESLint is working incorrectly core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 22, 2019
@mysticatea mysticatea added this to Implemented, pending review in v6.0.0 Jun 22, 2019
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

In your view, should this be a patch release candidate?

@mysticatea
Copy link
Member Author

Yes, I think so.

@platinumazure platinumazure added the patch candidate This issue may necessitate a patch release in the next few days label Jun 22, 2019
@mysticatea mysticatea merged commit d07f3fa into master Jun 23, 2019
v6.0.0 automation moved this from Implemented, pending review to Done Jun 23, 2019
@mysticatea mysticatea deleted the issue11871 branch June 23, 2019 18:49
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Dec 21, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features patch candidate This issue may necessitate a patch release in the next few days
Projects
No open projects
v6.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

can't get plugin rules by CLIEngine#getRules
5 participants