Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add visualstudio as a formatter #11480

Merged
merged 1 commit into from Mar 6, 2019
Merged

Conversation

paleite
Copy link
Contributor

@paleite paleite commented Mar 5, 2019

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Added visualstudio as a formatter option

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Mar 5, 2019

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Mar 5, 2019
@paleite paleite changed the title Add visualstudio as a formatter Docs: Add visualstudio as a formatter Mar 5, 2019
@aladdin-add aladdin-add added enhancement This change enhances an existing feature of ESLint documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Mar 5, 2019
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure
Copy link
Member

platinumazure commented Mar 5, 2019

~~Hi @paleite, thanks for contributing!

I think this will be needed in the ESLint repository as well. Otherwise, this change will be overwritten during our next release.~~

Oops, thought this was the website for some reason.

@g-plane
Copy link
Member

g-plane commented Mar 5, 2019

@platinumazure This is real ESLint repository. Did you misunderstand anything?

@not-an-aardvark not-an-aardvark merged commit 0756128 into eslint:master Mar 6, 2019
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 3, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants