Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: use "file:" dependencies for internal rules/config #11465

Merged
merged 1 commit into from Mar 6, 2019

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Other, please explain:

What changes did you make? (Give an overview)

This updates the setup of our internal linting rules to use "file:" dependencies within the project, rather than the eslint-plugin-rulesdir package. If this works well, it could be a good alternative for packages like eslint-plugin-rulesdir and eslint-plugin-self.

Is there anything you'd like reviewers to focus on?

Nothing in particular

This updates the setup of our internal linting rules to use "file:" dependencies within the project, rather than the `eslint-plugin-rulesdir` package. If this works well, it could be a good alternative for packages like `eslint-plugin-rulesdir` and `eslint-plugin-self`.
@not-an-aardvark not-an-aardvark added the chore This change is not user-facing label Mar 3, 2019
@platinumazure
Copy link
Member

Thanks @not-an-aardvark, this looks interesting.

Out of curiosity, what problem are you trying to solve here?

@g-plane
Copy link
Member

g-plane commented Mar 3, 2019

@platinumazure VS Code doesn't work well with eslint-plugin-rulesdir.

@not-an-aardvark
Copy link
Member Author

It's generally pretty inconvenient for projects to use custom rules that are also developed alongside the project itself. (We use eslint-plugin-rulesdir, which requires the user to load the plugin and globally mutate it before ESLint loads it. It also has some problems with VSCode on Windows due to drive letter capitalization.) If we dogfood this and it works well, we could potentially document this pattern as a recommendation for users.

@platinumazure
Copy link
Member

Thanks @g-plane and @not-an-aardvark. Now I've caught up on the Gitter chat 😄

I'd like to wait to merge this until we know we don't need a patch release, just in case of any unexpected impact to users.

@not-an-aardvark not-an-aardvark merged commit f078f9a into master Mar 6, 2019
@not-an-aardvark not-an-aardvark deleted the use-file-dependencies branch March 6, 2019 08:07
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Sep 3, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants