New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: sort-keys throws Error at SpreadElement (fixes #11402) #11403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request! May you please add a test for this change?
edit: I also think it would be better to explicitly only do the SpreadElement
logic when the parent
of the SpreadElement
has type ObjectExpression
, rather than just doing a null check here.
Thanks for you prompt response and suggestions. I have added unit test and updated the code. (I am not quite familiar with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What is the delay for releasing this? |
@gajus we just published this in v5.14.1! 🚢 We do releases every other Friday and follow them up with a patch release, if there are any regressions like the one this fixed, on the following Monday. If you ever want to check on the status of a release, we always have an issue open with the |
Thank you |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fix #11402
Is there anything you'd like reviewers to focus on?