Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sort-keys throws Error at SpreadElement (fixes #11402) #11403

Merged
merged 3 commits into from Feb 18, 2019
Merged

Fix: sort-keys throws Error at SpreadElement (fixes #11402) #11403

merged 3 commits into from Feb 18, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Feb 15, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Fix #11402

Is there anything you'd like reviewers to focus on?

@jsf-clabot
Copy link

jsf-clabot commented Feb 15, 2019

CLA assistant check
All committers have signed the CLA.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Feb 15, 2019
@kristw kristw changed the title Update sort-keys.js Fix: sort-keys throws Error at SpreadElement (fixes #11402) Feb 15, 2019
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! May you please add a test for this change?

edit: I also think it would be better to explicitly only do the SpreadElement logic when the parent of the SpreadElement has type ObjectExpression, rather than just doing a null check here.

@not-an-aardvark not-an-aardvark added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion regression Something broke patch candidate This issue may necessitate a patch release in the next few days and removed triage An ESLint team member will look at this issue soon labels Feb 16, 2019
@kristw
Copy link
Contributor Author

kristw commented Feb 16, 2019

Thanks for you prompt response and suggestions. I have added unit test and updated the code. (I am not quite familiar with eslint code so please let me know if the fix is not what you mean.)

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gajus
Copy link
Contributor

gajus commented Feb 18, 2019

What is the delay for releasing this?

@btmills btmills merged commit 1d6e639 into eslint:master Feb 18, 2019
@btmills
Copy link
Member

btmills commented Feb 18, 2019

@gajus we just published this in v5.14.1! 🚢 We do releases every other Friday and follow them up with a patch release, if there are any regressions like the one this fixed, on the following Monday. If you ever want to check on the status of a release, we always have an issue open with the release tag to track the next release.

@gajus
Copy link
Contributor

gajus commented Feb 18, 2019

@gajus we just published this in v5.14.1! 🚢

Thank you

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 18, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly patch candidate This issue may necessitate a patch release in the next few days regression Something broke rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sort-keys: Cannot set property 'prevName' of null at SpreadElement
7 participants