New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Behavior of --init (fixes #11105) #11332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Slightly unrelated: Wondering if it might be possible to prepare a short video showing how this looks? Maybe not necessary for review, but could be cool to include in a blog post or on Twitter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited for this change! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! The implementation largely looks good -- I have a few minor UX suggestions.
lib/config/config-initializer.js
Outdated
default: "esm", | ||
choices: [ | ||
{ name: "JavaScript modules", value: "esm" }, | ||
{ name: "CommonJS", value: "commonjs" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect the wording here might be confusing, because many users aren't familiar with the term "CommonJS" or the distinction between the two module systems. Someone unfamiliar with modules might think, "well, I don't know what CommonJS means but I'm writing JavaScript, so I'm probably using JavaScript modules", when in fact most people using Node are probably using CommonJS.
Could we add some additional context to this question? I'm not sure what the best wording would be, but maybe it would look something like this:
- CommonJS (usually used if your code runs in Node.js)
- JavaScript modules (usually used if ...)
Alternatively, maybe we could put this question after the browser/node question and change the wording accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this is any less clear than what we had previously. Prior to this change, there were two questions:
- Do you use CommonJS?
- Do you use ES6 modules?
IMHO, it was more confusing before because we were not presenting the two options as related to each other. I worry about adding too many words to these options lest people stop reading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that asking two questions/adding too many words is not ideal. What about something like this?
Are you using
import
/export
syntax?
We would remove the explicit question/answer about CommonJS, and instead enable the commonjs
env when the user says they're both (a) using Node and (b) not using import
/export
syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to explicitly ask about CommonJS because it can be used in the browser, so we can't logically infer that if they're not using Node.js, then they must not be using CommonJS.
I'm not opposed to changing "JavaScript modules" to "import/export syntax", though, if you feel that makes it clearer.
message: "How would you like to use ESLint?", | ||
default: "problems", | ||
choices: [ | ||
{ name: "To check syntax only", value: "syntax" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the "check syntax only" option is a fairly niche use case -- most projects would benefit from at least using eslint:recommended
. Additionally, some users might not understand what "check syntax" means (it means "only report syntax errors" rather than "report bug-prone syntactic patterns"), or they might not have a clear understanding of how syntax errors differ from semantic errors.
In your view, is this preference sufficiently common that it's worth having an option for? I don't feel very strongly about it, but I'd prefer either:
- Removing it from the
--init
options, or - Moving it to the bottom of the three options here (if we wanted to retain ordering consistency, we could also just reverse the order of these options entirely).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We got some direct feedback a while ago that it wasn't clear ESLint could be used just for syntax checking. While it may be a niche case, I don't think it hurts anything to include it here. This way, new users can easily see that ESLint can be used for a number of different purposes.
I don't see the purpose of reversing the order of the options. Right now, there is a logical progression of options that include more functionality, and either way the common case is in the middle and the default.
As it is, the default selection in this menu is to check syntax and find problems
@g-plane @mysticatea can you take a look at the latest changes to make sure they're correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Still LGTM, thanks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Okay, I believe all of the outstanding issues have been addressed. Please check on this one more time. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of suggestions, but neither of them are blockers IMO.
Once #11384 is merged, I'll update to use "readonly". Then this will be ready to merge. |
Okay, I've updated to use "readonly" instead of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## The devDependency [eslint](https://github.com/eslint/eslint) was updated from `5.12.1` to `5.14.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v5.14.0</summary> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/85a04b319e6dfde1458174cd1d8c9e7d33da0871"><code>85a04b3</code></a> Fix: adds conditional for separateRequires in one-var (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310933694" data-permission-text="Issue title is private" data-url="eslint/eslint#10179" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/10179/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/10179">#10179</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="369993599" data-permission-text="Issue title is private" data-url="eslint/eslint#10980" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/10980/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/10980">#10980</a>) (Scott Stern)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0c02932f1b2e2a85809e84617efa1b8836c19cfb"><code>0c02932</code></a> Upgrade: espree@5.0.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410918526" data-permission-text="Issue title is private" data-url="eslint/eslint#11401" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11401/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11401">#11401</a>) (Ilya Volodin)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/104ae881d0b21e9c64e006b2a2c21535cef0ad28"><code>104ae88</code></a> Docs: Update governance doc with reviewers status (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410806033" data-permission-text="Issue title is private" data-url="eslint/eslint#11399" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11399/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11399">#11399</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8ac6adaaf7a88e160899e7f438a4cfd655eb6e"><code>ab8ac6a</code></a> Fix: Support boundary spread elements in sort-keys (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="387528357" data-permission-text="Issue title is private" data-url="eslint/eslint#11158" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11158/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11158">#11158</a>) (Jakub Rożek)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a23d1975d48841eafdead1a1357e2af842f688bc"><code>a23d197</code></a> New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="176681678" data-permission-text="Issue title is private" data-url="eslint/eslint#7145" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/7145/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/7145">#7145</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="396278013" data-permission-text="Issue title is private" data-url="eslint/eslint#11243" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11243/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11243">#11243</a>) (richie3366)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e25e7aa3ea1e8c9b3cd3242acda6d4a5572c2c6a"><code>e25e7aa</code></a> Fix: comma-spacing ignore comma before closing paren (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401050405" data-permission-text="Issue title is private" data-url="eslint/eslint#11295" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11295/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11295">#11295</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408608672" data-permission-text="Issue title is private" data-url="eslint/eslint#11374" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11374/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11374">#11374</a>) (Pig Fang)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a1f7c44ea9efbd9393889c1cc91b74260e0a8e02"><code>a1f7c44</code></a> Docs: fix space-before-blocks correct code for "classes": "never" (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410161351" data-permission-text="Issue title is private" data-url="eslint/eslint#11391" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11391/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11391">#11391</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/14f58a2bec4d6aade0de22771c378b86b1e51959"><code>14f58a2</code></a> Docs: fix grammar in object-curly-spacing docs (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410128788" data-permission-text="Issue title is private" data-url="eslint/eslint#11389" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11389/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11389">#11389</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d3e9a27bbba30008a610df59e82b7192f0ecc3a3"><code>d3e9a27</code></a> Docs: fix grammar in “those who says” (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410156839" data-permission-text="Issue title is private" data-url="eslint/eslint#11390" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11390/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11390">#11390</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ea8e8045ba0e6c1e1015104346af962f3e16fd81"><code>ea8e804</code></a> Docs: Add note about support for object spread (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="385126685" data-permission-text="Issue title is private" data-url="eslint/eslint#11136" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11136/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11136">#11136</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410444446" data-permission-text="Issue title is private" data-url="eslint/eslint#11395" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11395/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11395">#11395</a>) (Steven Thomas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/95aa3fdb392d265e6c3d813d54076458e88e7ad8"><code>95aa3fd</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/51c497298a15ad296a2b1f8fc397df687976b836"><code>51c4972</code></a> Update: Behavior of --init (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="382337303" data-permission-text="Issue title is private" data-url="eslint/eslint#11105" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11105/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11105">#11105</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404422915" data-permission-text="Issue title is private" data-url="eslint/eslint#11332" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11332/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11332">#11332</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ad7a38097c32a91e5a831ef1bc8933601532576c"><code>ad7a380</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/550de1e611a1e9af873bcb18d74cf2056e8d2e1b"><code>550de1e</code></a> Update: use <code>default</code> keyword in JSON schema (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="294113624" data-permission-text="Issue title is private" data-url="eslint/eslint#9929" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9929/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9929">#9929</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="400761608" data-permission-text="Issue title is private" data-url="eslint/eslint#11288" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11288/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11288">#11288</a>) (Pig Fang)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/983c5201210d7a4ffab0b3d05ab9919c0754e5ca"><code>983c520</code></a> Update: Use 'readonly' and 'writable' for globals (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="407305063" data-permission-text="Issue title is private" data-url="eslint/eslint#11359" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11359/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11359">#11359</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409412748" data-permission-text="Issue title is private" data-url="eslint/eslint#11384" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11384/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11384">#11384</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/f1d3a7ee7c82365989e219b1dae379f08f6dd526"><code>f1d3a7e</code></a> Upgrade: some deps (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408523961" data-permission-text="Issue title is private" data-url="eslint/eslint#11372" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11372/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11372">#11372</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408528993" data-permission-text="Issue title is private" data-url="eslint/eslint#11373" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11373/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11373">#11373</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3e0c4176eff085498b813f8ba1732d7ed6ee44f8"><code>3e0c417</code></a> Docs: Fix grammar in “there’s nothing prevent you” (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409641227" data-permission-text="Issue title is private" data-url="eslint/eslint#11385" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11385/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11385">#11385</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/de988bc909b491366ad0cd9bc83f4d6de42d041a"><code>de988bc</code></a> Docs: Fix grammar: Spacing improve -> Spacing improves (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409657539" data-permission-text="Issue title is private" data-url="eslint/eslint#11386" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11386/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11386">#11386</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1309dfdebb5595460b79dcac20df6a1f109e7566"><code>1309dfd</code></a> Revert "Build: fix test failure on Node 11 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="382010541" data-permission-text="Issue title is private" data-url="eslint/eslint#11100" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11100/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11100">#11100</a>)" (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408638354" data-permission-text="Issue title is private" data-url="eslint/eslint#11375" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11375/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11375">#11375</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1e56897db3e254e0aef6d2fe3274157fc379c79e"><code>1e56897</code></a> Docs: “the function actually use”: use -> uses (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409158739" data-permission-text="Issue title is private" data-url="eslint/eslint#11380" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11380/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11380">#11380</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5a71bc95a7e961b1b1b77022645e0bd9cdd08dc0"><code>5a71bc9</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/82a58ce26b282fd80335b3ac4fc88f21266c3ba1"><code>82a58ce</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/546d355ace65631e27de859baea3ffcc50e0ad2c"><code>546d355</code></a> Docs: Update README with latest sponsors/team data (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408880022" data-permission-text="Issue title is private" data-url="eslint/eslint#11378" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11378/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11378">#11378</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c0df9febb7c7e045ababc10b88dbcbb3f28c724c"><code>c0df9fe</code></a> Docs: <code>...</code> is not an operator (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="395406535" data-permission-text="Issue title is private" data-url="eslint/eslint#11232" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11232/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11232">#11232</a>) (Felix Kling)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7ecfdefaeadb772f8b96ffe37c4a2c97fde0da16"><code>7ecfdef</code></a> Docs: update typescript parser (refs <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408420749" data-permission-text="Issue title is private" data-url="eslint/eslint#11368" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11368/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11368">#11368</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408421449" data-permission-text="Issue title is private" data-url="eslint/eslint#11369" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11369/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11369">#11369</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3c90dd7e25cf97833deddb11cfbc107a5663ac08"><code>3c90dd7</code></a> Update: remove prefer-spread autofix (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404394299" data-permission-text="Issue title is private" data-url="eslint/eslint#11330" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11330/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11330">#11330</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408234262" data-permission-text="Issue title is private" data-url="eslint/eslint#11365" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11365/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11365">#11365</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5eb3121b82c1837da0c3021b7d9384bb30832e36"><code>5eb3121</code></a> Update: add fixer for <code>prefer-destructuring</code> (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="386647796" data-permission-text="Issue title is private" data-url="eslint/eslint#11151" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11151/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11151">#11151</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401382591" data-permission-text="Issue title is private" data-url="eslint/eslint#11301" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11301/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11301">#11301</a>) (golopot)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/173eb38cdb3e4673cba947521f27158828186d77"><code>173eb38</code></a> Docs: Clarify ecmaVersion doesn't imply globals (refs <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="286511859" data-permission-text="Issue title is private" data-url="eslint/eslint#9812" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9812/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9812">#9812</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408046817" data-permission-text="Issue title is private" data-url="eslint/eslint#11364" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11364/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11364">#11364</a>) (Keith Maxwell)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/84ce72fdeba082b7b132e4ac6b714fb1a93831b7"><code>84ce72f</code></a> Fix: Remove extraneous linefeeds in <code>one-var</code> fixer (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="348084571" data-permission-text="Issue title is private" data-url="eslint/eslint#10741" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/10741/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/10741">#10741</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="368549184" data-permission-text="Issue title is private" data-url="eslint/eslint#10955" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/10955/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/10955">#10955</a>) (st-sloth)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/389362a06ac6601512b872d3e843c7371f2a1bcc"><code>389362a</code></a> Docs: clarify motivation for no-prototype-builtins (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="407049599" data-permission-text="Issue title is private" data-url="eslint/eslint#11356" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11356/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11356">#11356</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/533d240b0811f663494cb213b06cc9e51e1ff2d0"><code>533d240</code></a> Update: no-shadow-restricted-names lets unassigned vars shadow undefined (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="405506188" data-permission-text="Issue title is private" data-url="eslint/eslint#11341" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11341/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11341">#11341</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d0e823aef196a6564c87a78b72c1ef980ce67af9"><code>d0e823a</code></a> Update: Make --init run js config files through linter (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="294550736" data-permission-text="Issue title is private" data-url="eslint/eslint#9947" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9947/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9947">#9947</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404963393" data-permission-text="Issue title is private" data-url="eslint/eslint#11337" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11337/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11337">#11337</a>) (Brian Kurek)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/92fc2f4f3faf8aeaae8a8e71db0de405404fb6c3"><code>92fc2f4</code></a> Fix: CircularJSON dependency warning (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="377112659" data-permission-text="Issue title is private" data-url="eslint/eslint#11052" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11052/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11052">#11052</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="402687981" data-permission-text="Issue title is private" data-url="eslint/eslint#11314" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11314/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11314">#11314</a>) (Terry)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4dd19a3c4c037adc860a65e96f2ba3eeccace1de"><code>4dd19a3</code></a> Docs: mention 'prefer-spread' in docs of 'no-useless-call' (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406005713" data-permission-text="Issue title is private" data-url="eslint/eslint#11348" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11348/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11348">#11348</a>) (Klaus Meinhardt)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4fd83d5ec47a6a7b81cd8801c3bd63d27ea1c7c4"><code>4fd83d5</code></a> Docs: fix a misleading example in one-var (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406350534" data-permission-text="Issue title is private" data-url="eslint/eslint#11350" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11350/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11350">#11350</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/9441ce77b7228f2c4562e158a10905afe11f31f2"><code>9441ce7</code></a> Chore: update incorrect tests to fix build failing (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406418834" data-permission-text="Issue title is private" data-url="eslint/eslint#11354" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11354/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11354">#11354</a>) (薛定谔的猫)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 51 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/af9688b7c4f6a3afe1b0ca5ba2f475c545e0309b"><code>af9688b</code></a> <code>5.14.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0ce3ac753017db813fb130d6563d524e29e20072"><code>0ce3ac7</code></a> <code>Build: changelog update for 5.14.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/85a04b319e6dfde1458174cd1d8c9e7d33da0871"><code>85a04b3</code></a> <code>Fix: adds conditional for separateRequires in one-var (fixes #10179) (#10980)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0c02932f1b2e2a85809e84617efa1b8836c19cfb"><code>0c02932</code></a> <code>Upgrade: espree@5.0.1 (#11401)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/104ae881d0b21e9c64e006b2a2c21535cef0ad28"><code>104ae88</code></a> <code>Docs: Update governance doc with reviewers status (#11399)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8ac6adaaf7a88e160899e7f438a4cfd655eb6e"><code>ab8ac6a</code></a> <code>Fix: Support boundary spread elements in sort-keys (#11158)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a23d1975d48841eafdead1a1357e2af842f688bc"><code>a23d197</code></a> <code>New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes #7145) (#11243)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e25e7aa3ea1e8c9b3cd3242acda6d4a5572c2c6a"><code>e25e7aa</code></a> <code>Fix: comma-spacing ignore comma before closing paren (fixes #11295) (#11374)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a1f7c44ea9efbd9393889c1cc91b74260e0a8e02"><code>a1f7c44</code></a> <code>Docs: fix space-before-blocks correct code for "classes": "never" (#11391)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/14f58a2bec4d6aade0de22771c378b86b1e51959"><code>14f58a2</code></a> <code>Docs: fix grammar in object-curly-spacing docs (#11389)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d3e9a27bbba30008a610df59e82b7192f0ecc3a3"><code>d3e9a27</code></a> <code>Docs: fix grammar in “those who says” (#11390)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ea8e8045ba0e6c1e1015104346af962f3e16fd81"><code>ea8e804</code></a> <code>Docs: Add note about support for object spread (fixes #11136) (#11395)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/95aa3fdb392d265e6c3d813d54076458e88e7ad8"><code>95aa3fd</code></a> <code>Docs: Update README team and sponsors</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/51c497298a15ad296a2b1f8fc397df687976b836"><code>51c4972</code></a> <code>Update: Behavior of --init (fixes #11105) (#11332)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ad7a38097c32a91e5a831ef1bc8933601532576c"><code>ad7a380</code></a> <code>Docs: Update README team and sponsors</code></li> </ul> <p>There are 51 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/faf3c4eda0d27323630d0bc103a99dd0ecffe842...af9688b7c4f6a3afe1b0ca5ba2f475c545e0309b">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴
## The devDependency [eslint](https://github.com/eslint/eslint) was updated from `5.7.0` to `5.14.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for v5.14.0</summary> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/85a04b319e6dfde1458174cd1d8c9e7d33da0871"><code>85a04b3</code></a> Fix: adds conditional for separateRequires in one-var (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="310933694" data-permission-text="Issue title is private" data-url="eslint/eslint#10179" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/10179/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/10179">#10179</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="369993599" data-permission-text="Issue title is private" data-url="eslint/eslint#10980" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/10980/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/10980">#10980</a>) (Scott Stern)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0c02932f1b2e2a85809e84617efa1b8836c19cfb"><code>0c02932</code></a> Upgrade: espree@5.0.1 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410918526" data-permission-text="Issue title is private" data-url="eslint/eslint#11401" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11401/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11401">#11401</a>) (Ilya Volodin)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/104ae881d0b21e9c64e006b2a2c21535cef0ad28"><code>104ae88</code></a> Docs: Update governance doc with reviewers status (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410806033" data-permission-text="Issue title is private" data-url="eslint/eslint#11399" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11399/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11399">#11399</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8ac6adaaf7a88e160899e7f438a4cfd655eb6e"><code>ab8ac6a</code></a> Fix: Support boundary spread elements in sort-keys (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="387528357" data-permission-text="Issue title is private" data-url="eslint/eslint#11158" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11158/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11158">#11158</a>) (Jakub Rożek)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a23d1975d48841eafdead1a1357e2af842f688bc"><code>a23d197</code></a> New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="176681678" data-permission-text="Issue title is private" data-url="eslint/eslint#7145" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/7145/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/7145">#7145</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="396278013" data-permission-text="Issue title is private" data-url="eslint/eslint#11243" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11243/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11243">#11243</a>) (richie3366)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e25e7aa3ea1e8c9b3cd3242acda6d4a5572c2c6a"><code>e25e7aa</code></a> Fix: comma-spacing ignore comma before closing paren (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401050405" data-permission-text="Issue title is private" data-url="eslint/eslint#11295" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11295/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11295">#11295</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408608672" data-permission-text="Issue title is private" data-url="eslint/eslint#11374" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11374/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11374">#11374</a>) (Pig Fang)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a1f7c44ea9efbd9393889c1cc91b74260e0a8e02"><code>a1f7c44</code></a> Docs: fix space-before-blocks correct code for "classes": "never" (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410161351" data-permission-text="Issue title is private" data-url="eslint/eslint#11391" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11391/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11391">#11391</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/14f58a2bec4d6aade0de22771c378b86b1e51959"><code>14f58a2</code></a> Docs: fix grammar in object-curly-spacing docs (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410128788" data-permission-text="Issue title is private" data-url="eslint/eslint#11389" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11389/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11389">#11389</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d3e9a27bbba30008a610df59e82b7192f0ecc3a3"><code>d3e9a27</code></a> Docs: fix grammar in “those who says” (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410156839" data-permission-text="Issue title is private" data-url="eslint/eslint#11390" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11390/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11390">#11390</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ea8e8045ba0e6c1e1015104346af962f3e16fd81"><code>ea8e804</code></a> Docs: Add note about support for object spread (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="385126685" data-permission-text="Issue title is private" data-url="eslint/eslint#11136" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11136/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11136">#11136</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="410444446" data-permission-text="Issue title is private" data-url="eslint/eslint#11395" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11395/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11395">#11395</a>) (Steven Thomas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/95aa3fdb392d265e6c3d813d54076458e88e7ad8"><code>95aa3fd</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/51c497298a15ad296a2b1f8fc397df687976b836"><code>51c4972</code></a> Update: Behavior of --init (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="382337303" data-permission-text="Issue title is private" data-url="eslint/eslint#11105" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11105/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11105">#11105</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404422915" data-permission-text="Issue title is private" data-url="eslint/eslint#11332" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11332/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11332">#11332</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ad7a38097c32a91e5a831ef1bc8933601532576c"><code>ad7a380</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/550de1e611a1e9af873bcb18d74cf2056e8d2e1b"><code>550de1e</code></a> Update: use <code>default</code> keyword in JSON schema (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="294113624" data-permission-text="Issue title is private" data-url="eslint/eslint#9929" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9929/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9929">#9929</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="400761608" data-permission-text="Issue title is private" data-url="eslint/eslint#11288" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11288/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11288">#11288</a>) (Pig Fang)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/983c5201210d7a4ffab0b3d05ab9919c0754e5ca"><code>983c520</code></a> Update: Use 'readonly' and 'writable' for globals (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="407305063" data-permission-text="Issue title is private" data-url="eslint/eslint#11359" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11359/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11359">#11359</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409412748" data-permission-text="Issue title is private" data-url="eslint/eslint#11384" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11384/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11384">#11384</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/f1d3a7ee7c82365989e219b1dae379f08f6dd526"><code>f1d3a7e</code></a> Upgrade: some deps (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408523961" data-permission-text="Issue title is private" data-url="eslint/eslint#11372" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11372/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11372">#11372</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408528993" data-permission-text="Issue title is private" data-url="eslint/eslint#11373" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11373/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11373">#11373</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3e0c4176eff085498b813f8ba1732d7ed6ee44f8"><code>3e0c417</code></a> Docs: Fix grammar in “there’s nothing prevent you” (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409641227" data-permission-text="Issue title is private" data-url="eslint/eslint#11385" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11385/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11385">#11385</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/de988bc909b491366ad0cd9bc83f4d6de42d041a"><code>de988bc</code></a> Docs: Fix grammar: Spacing improve -> Spacing improves (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409657539" data-permission-text="Issue title is private" data-url="eslint/eslint#11386" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11386/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11386">#11386</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1309dfdebb5595460b79dcac20df6a1f109e7566"><code>1309dfd</code></a> Revert "Build: fix test failure on Node 11 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="382010541" data-permission-text="Issue title is private" data-url="eslint/eslint#11100" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11100/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11100">#11100</a>)" (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408638354" data-permission-text="Issue title is private" data-url="eslint/eslint#11375" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11375/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11375">#11375</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/1e56897db3e254e0aef6d2fe3274157fc379c79e"><code>1e56897</code></a> Docs: “the function actually use”: use -> uses (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="409158739" data-permission-text="Issue title is private" data-url="eslint/eslint#11380" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11380/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11380">#11380</a>) (PoziWorld)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5a71bc95a7e961b1b1b77022645e0bd9cdd08dc0"><code>5a71bc9</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/82a58ce26b282fd80335b3ac4fc88f21266c3ba1"><code>82a58ce</code></a> Docs: Update README team and sponsors (ESLint Jenkins)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/546d355ace65631e27de859baea3ffcc50e0ad2c"><code>546d355</code></a> Docs: Update README with latest sponsors/team data (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408880022" data-permission-text="Issue title is private" data-url="eslint/eslint#11378" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11378/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11378">#11378</a>) (Nicholas C. Zakas)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/c0df9febb7c7e045ababc10b88dbcbb3f28c724c"><code>c0df9fe</code></a> Docs: <code>...</code> is not an operator (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="395406535" data-permission-text="Issue title is private" data-url="eslint/eslint#11232" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11232/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11232">#11232</a>) (Felix Kling)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/7ecfdefaeadb772f8b96ffe37c4a2c97fde0da16"><code>7ecfdef</code></a> Docs: update typescript parser (refs <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408420749" data-permission-text="Issue title is private" data-url="eslint/eslint#11368" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11368/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11368">#11368</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408421449" data-permission-text="Issue title is private" data-url="eslint/eslint#11369" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11369/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11369">#11369</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/3c90dd7e25cf97833deddb11cfbc107a5663ac08"><code>3c90dd7</code></a> Update: remove prefer-spread autofix (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404394299" data-permission-text="Issue title is private" data-url="eslint/eslint#11330" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11330/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11330">#11330</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408234262" data-permission-text="Issue title is private" data-url="eslint/eslint#11365" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11365/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11365">#11365</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/5eb3121b82c1837da0c3021b7d9384bb30832e36"><code>5eb3121</code></a> Update: add fixer for <code>prefer-destructuring</code> (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="386647796" data-permission-text="Issue title is private" data-url="eslint/eslint#11151" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11151/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11151">#11151</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="401382591" data-permission-text="Issue title is private" data-url="eslint/eslint#11301" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11301/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11301">#11301</a>) (golopot)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/173eb38cdb3e4673cba947521f27158828186d77"><code>173eb38</code></a> Docs: Clarify ecmaVersion doesn't imply globals (refs <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="286511859" data-permission-text="Issue title is private" data-url="eslint/eslint#9812" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9812/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9812">#9812</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="408046817" data-permission-text="Issue title is private" data-url="eslint/eslint#11364" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11364/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11364">#11364</a>) (Keith Maxwell)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/84ce72fdeba082b7b132e4ac6b714fb1a93831b7"><code>84ce72f</code></a> Fix: Remove extraneous linefeeds in <code>one-var</code> fixer (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="348084571" data-permission-text="Issue title is private" data-url="eslint/eslint#10741" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/10741/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/10741">#10741</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="368549184" data-permission-text="Issue title is private" data-url="eslint/eslint#10955" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/10955/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/10955">#10955</a>) (st-sloth)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/389362a06ac6601512b872d3e843c7371f2a1bcc"><code>389362a</code></a> Docs: clarify motivation for no-prototype-builtins (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="407049599" data-permission-text="Issue title is private" data-url="eslint/eslint#11356" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11356/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11356">#11356</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/533d240b0811f663494cb213b06cc9e51e1ff2d0"><code>533d240</code></a> Update: no-shadow-restricted-names lets unassigned vars shadow undefined (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="405506188" data-permission-text="Issue title is private" data-url="eslint/eslint#11341" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11341/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11341">#11341</a>) (Teddy Katz)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d0e823aef196a6564c87a78b72c1ef980ce67af9"><code>d0e823a</code></a> Update: Make --init run js config files through linter (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="294550736" data-permission-text="Issue title is private" data-url="eslint/eslint#9947" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/9947/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/9947">#9947</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="404963393" data-permission-text="Issue title is private" data-url="eslint/eslint#11337" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11337/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11337">#11337</a>) (Brian Kurek)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/92fc2f4f3faf8aeaae8a8e71db0de405404fb6c3"><code>92fc2f4</code></a> Fix: CircularJSON dependency warning (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="377112659" data-permission-text="Issue title is private" data-url="eslint/eslint#11052" data-hovercard-type="issue" data-hovercard-url="/eslint/eslint/issues/11052/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/issues/11052">#11052</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="402687981" data-permission-text="Issue title is private" data-url="eslint/eslint#11314" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11314/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11314">#11314</a>) (Terry)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4dd19a3c4c037adc860a65e96f2ba3eeccace1de"><code>4dd19a3</code></a> Docs: mention 'prefer-spread' in docs of 'no-useless-call' (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406005713" data-permission-text="Issue title is private" data-url="eslint/eslint#11348" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11348/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11348">#11348</a>) (Klaus Meinhardt)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4fd83d5ec47a6a7b81cd8801c3bd63d27ea1c7c4"><code>4fd83d5</code></a> Docs: fix a misleading example in one-var (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406350534" data-permission-text="Issue title is private" data-url="eslint/eslint#11350" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11350/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11350">#11350</a>) (薛定谔的猫)</li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/9441ce77b7228f2c4562e158a10905afe11f31f2"><code>9441ce7</code></a> Chore: update incorrect tests to fix build failing (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="406418834" data-permission-text="Issue title is private" data-url="eslint/eslint#11354" data-hovercard-type="pull_request" data-hovercard-url="/eslint/eslint/pull/11354/hovercard" href="https://urls.greenkeeper.io/eslint/eslint/pull/11354">#11354</a>) (薛定谔的猫)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 145 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/af9688b7c4f6a3afe1b0ca5ba2f475c545e0309b"><code>af9688b</code></a> <code>5.14.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0ce3ac753017db813fb130d6563d524e29e20072"><code>0ce3ac7</code></a> <code>Build: changelog update for 5.14.0</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/85a04b319e6dfde1458174cd1d8c9e7d33da0871"><code>85a04b3</code></a> <code>Fix: adds conditional for separateRequires in one-var (fixes #10179) (#10980)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/0c02932f1b2e2a85809e84617efa1b8836c19cfb"><code>0c02932</code></a> <code>Upgrade: espree@5.0.1 (#11401)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/104ae881d0b21e9c64e006b2a2c21535cef0ad28"><code>104ae88</code></a> <code>Docs: Update governance doc with reviewers status (#11399)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ab8ac6adaaf7a88e160899e7f438a4cfd655eb6e"><code>ab8ac6a</code></a> <code>Fix: Support boundary spread elements in sort-keys (#11158)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a23d1975d48841eafdead1a1357e2af842f688bc"><code>a23d197</code></a> <code>New: add allowSingleLineBlocks opt. to padded-blocks rule (fixes #7145) (#11243)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/e25e7aa3ea1e8c9b3cd3242acda6d4a5572c2c6a"><code>e25e7aa</code></a> <code>Fix: comma-spacing ignore comma before closing paren (fixes #11295) (#11374)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/a1f7c44ea9efbd9393889c1cc91b74260e0a8e02"><code>a1f7c44</code></a> <code>Docs: fix space-before-blocks correct code for "classes": "never" (#11391)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/14f58a2bec4d6aade0de22771c378b86b1e51959"><code>14f58a2</code></a> <code>Docs: fix grammar in object-curly-spacing docs (#11389)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/d3e9a27bbba30008a610df59e82b7192f0ecc3a3"><code>d3e9a27</code></a> <code>Docs: fix grammar in “those who says” (#11390)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ea8e8045ba0e6c1e1015104346af962f3e16fd81"><code>ea8e804</code></a> <code>Docs: Add note about support for object spread (fixes #11136) (#11395)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/95aa3fdb392d265e6c3d813d54076458e88e7ad8"><code>95aa3fd</code></a> <code>Docs: Update README team and sponsors</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/51c497298a15ad296a2b1f8fc397df687976b836"><code>51c4972</code></a> <code>Update: Behavior of --init (fixes #11105) (#11332)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/ad7a38097c32a91e5a831ef1bc8933601532576c"><code>ad7a380</code></a> <code>Docs: Update README team and sponsors</code></li> </ul> <p>There are 145 commits in total.</p> <p>See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/77bb2071b4b9f78929bdf4b97a016fef106348e6...af9688b7c4f6a3afe1b0ca5ba2f475c545e0309b">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Updates the behavior of
--init
per #11105What changes did you make? (Give an overview)
Rearranged the questions that are asked using
--init
. We now assume the latest version of ECMAScript is desired.Also, there was a bug where if you chose a style guide the resulting config would have nothing but the resulting style guide. I fixed that.
The majority of the work was in rearranging the order of the questions. That part is pretty hard to follow but I did my best to clean it up for this round of changes. If we decide to remove autoconfig, I'd do some deeper cleaning.
In addition to the unit tests, I manually tested that each path through the questionnaire works locally.
Is there anything you'd like reviewers to focus on?
Anything that I missed?