Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: false positive in no-constant-condition (fixes #11306) #11308

Merged
merged 1 commit into from Feb 1, 2019

Conversation

g-plane
Copy link
Member

@g-plane g-plane commented Jan 23, 2019

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

What changes did you make? (Give an overview)
Fixes #11306

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 23, 2019
@g-plane g-plane added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jan 23, 2019
@adolli
Copy link

adolli commented Jan 23, 2019

good job!

@btmills btmills merged commit 5b14ad1 into master Feb 1, 2019
@g-plane g-plane deleted the issue-11306 branch February 2, 2019 00:53
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 1, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-constant-condition regression in v5.12.1
4 participants