Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: use local function to append "s" instead of a package #11293

Merged
merged 1 commit into from Feb 1, 2019
Merged

Chore: use local function to append "s" instead of a package #11293

merged 1 commit into from Feb 1, 2019

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented Jan 19, 2019

What changes did you make? (Give an overview)

Use a local function to append "s" instead of an npm package.

The proposed code matches the way other formatters in ESLint handle pluralization, which seems simple enough to not require an additional package for.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jan 19, 2019
g-plane
g-plane reviewed Jan 19, 2019
View reviewed changes
lib/formatters/table.js Outdated Show resolved Hide resolved
@g-plane g-plane added evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion formatter Relates to the formatters bundled with ESLint and removed triage An ESLint team member will look at this issue soon labels Jan 19, 2019
@g-plane
Copy link
Member

g-plane commented Jan 19, 2019 •
edited

@Krinkle Can you check why the tests failed? Thanks!

Krinkle
Krinkle commented Jan 19, 2019
View reviewed changes
lib/formatters/table.js Outdated Show resolved Hide resolved
@Krinkle
Chore: use local function to append "s" instead of a package
e6530b5 
This matches the way other formatters handle pluralization, which
seems simple enough to not require an additional package.
platinumazure
platinumazure approved these changes Jan 19, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.

I think it would be slightly better to pluralize only the word "Error" or "Warning" without having the number in the string, but I won't consider it a blocker.

Waiting for another set of eyes before merging. Thanks!

@btmills btmills merged commit 91c8884 into eslint:master Feb 1, 2019
@Krinkle Krinkle deleted the rm-plural branch February 2, 2019 23:37
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 1, 2019
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@g-plane g-plane g-plane left review comments

@platinumazure platinumazure platinumazure approved these changes

@ilyavolodin ilyavolodin ilyavolodin approved these changes

@btmills btmills btmills approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion formatter Relates to the formatters bundled with ESLint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Krinkle @g-plane @platinumazure @ilyavolodin @btmills