Docs: Fix max-lines-per-function correct code's max value #10513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
platinumazure
approved these changes
Jun 23, 2018
platinumazure
added
rule
matt-riley
pushed a commit
to matt-riley/gql_boilerplate
that referenced
this pull request
Jun 26, 2018
## Version **5.0.1** of **[eslint](https://github.com/eslint/eslint)** was just published. <table> <tr> <th align=left> Dependency </th> <td> <code>[eslint](https://github.com/eslint/eslint)</code> </td> </tr> <tr> <th align=left> Current Version </th> <td> 5.0.0 </td> </tr> <tr> <th align=left> Type </th> <td> devDependency </td> </tr> </table> The version **5.0.1** is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. It might be worth looking into these changes and trying to get this project onto the latest version of eslint. If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update. --- <details> <summary>Release Notes</summary> <strong>v5.0.1</strong> <ul> <li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/eslint/commit/196c1021c070e52259f2ceccc4f141bdb7456c60"><tt>196c102</tt></a> Fix: valid-jsdoc should allow optional returns for async (fixes <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="324854620" data-permission-text="Issue title is private" data-url="eslint/eslint#10386" href="https://urls.greenkeeper.io/eslint/eslint/issues/10386">#10386</a>) (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="332691684" data-permission-text="Issue title is private" data-url="eslint/eslint#10480" href="https://urls.greenkeeper.io/eslint/eslint/pull/10480">#10480</a>) (Mark Banner)</li> <li><a class="commit-link" href="https://urls.greenkeeper.io/eslint/eslint/commit/4c823bdf42af8f9a9fcf47473e48a99758881cf4"><tt>4c823bd</tt></a> Docs: Fix max-lines-per-function correct code's max value (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="335122700" data-permission-text="Issue title is private" data-url="eslint/eslint#10513" href="https://urls.greenkeeper.io/eslint/eslint/pull/10513">#10513</a>) (Rhys Bower)</li> </ul> </details> <details> <summary>Commits</summary> <p>The new version differs by 4 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/caeb223c4f7b0b6fe35e5348ae0df4c6446b5bed"><code>caeb223</code></a> <code>5.0.1</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/125dc34637138b240976f0f76ef53476b15f08b3"><code>125dc34</code></a> <code>Build: changelog update for 5.0.1</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/196c1021c070e52259f2ceccc4f141bdb7456c60"><code>196c102</code></a> <code>Fix: valid-jsdoc should allow optional returns for async (fixes #10386) (#10480)</code></li> <li><a href="https://urls.greenkeeper.io/eslint/eslint/commit/4c823bdf42af8f9a9fcf47473e48a99758881cf4"><code>4c823bd</code></a> <code>Docs: Fix max-lines-per-function correct code's max value (#10513)</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/eslint/eslint/compare/36ced0afca1bc0e1cbbc13cbeaacf9e7cf00841f...caeb223c4f7b0b6fe35e5348ae0df4c6446b5bed">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Fix the documentation for the max-lines-per-function rule to display the correct code's max value.
Is there anything you'd like reviewers to focus on?
Verify that max value for the correct code has been changed from 2 to 3.