Fix: check destructuring for "no-shadow-restricted-names" (fixes #10467)

[g-plane]

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

What changes did you make? (Give an overview)
fix #10467

Is there anything you'd like reviewers to focus on?
@mysticatea said that this rule can be merged into the no-shadow rule, but I think this should be done in another commit/PR.

[aladdin-add]

could you please add some more tests like:

var undefined = "foo";
var foo = bar, undefined = bar;

[g-plane]

What's the difference between the existing tests?

[aladdin-add]

oh, my apologies! I didn't notice it was already there!

[mysticatea]

Thank you for the contributing!

However, I'd like to point out some matters.

• It should handle destructuring in checkForViolation function rather than VariableDeclarator handler because function parameters can have it as well.

• It should handle the following things as well:

  • nested destructuring (e.g. var {a: {b: {undefined}}} = obj).
  • renaming in destructuring (e.g. var {a: undefined} = obj).
  • default values (e.g. var {a: undefined = 0} = obj).
  • rest elements (e.g. var {a, ...undefined} = obj).

  So I'd like to recommend to use context.getDeclaredVariables API.

• Array.prototype.map is the method which converts an array to another array. In this case Array.prototype.forEach is more proper.

• Upgrade: espree@next (fixes #10392) #10429 modifies the same file, so I'm worried to need resolve confliction later.

[g-plane]

Can I replace [].call.map in the rule file?

[mysticatea]

I replaced it in #10429.

[g-plane]

Updated.

[mysticatea]

Looks good. But it can be simplified more:

        return {
            "VariableDeclaration, :function, CatchClause"(node) {
                for (const variable of context.getDeclaredVariables(node)) {
                    if (variable.defs.length > 0 && RESTRICTED.includes(variable.name)) {
                        context.report({
                            node: variable.defs[0].name,
                            message: "Shadowing of global property '{{idName}}'.",
                            data: {
                                idName: variable.name
                            }
                        });
                    }
                }
            }
        };

[g-plane]

Updated again.

[mysticatea]

LGTM, thank you very much!

[platinumazure]

LGTM, thanks!

[platinumazure]

Merged, thanks @g-plane for contributing!