Fix: object-curly-newline minProperties w/default export (fixes #10101) #10103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minProperties only tracks ImportSpecifier and ExportSpecifier nodes
platinumazure
added
bug
not-an-aardvark
approved these changes
Mar 19, 2018
gyandeeps
approved these changes
Mar 21, 2018
This was referenced Mar 22, 2018
Merged
This was referenced Mar 22, 2018
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minProperties only tracks ImportSpecifier and ExportSpecifier nodes
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
See #10101.
What changes did you make? (Give an overview)
The
object-curly-newlinerule used to count allspecifiersunder anImportDeclarationorExportDeclarationnode when determining if there are enough specifiers to require line breaks. However, ImportDefaultSpecifier and ImportNamespaceSpecifier nodes are not actually part of the "object" (i.e., nodes surrounded by curly brace tokens), so they should be ignored by this rule. This change fixes the logic to only check for the count ofImportSpecifierorExportSpecifiernodes associated with theImportDeclarationorExportDeclarationnodes.Is there anything you'd like reviewers to focus on?
Any other unit tests I should add?