Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add eslint version to error output #9037

Closed
art-in opened this issue Jul 29, 2017 · 5 comments · Fixed by #9071
Closed

add eslint version to error output #9037

art-in opened this issue Jul 29, 2017 · 5 comments · Fixed by #9071
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint

Comments

@art-in
Copy link

art-in commented Jul 29, 2017

it would be useful to have eslint version in error output

eg. #9024 - when eslint cannot parse configuration, output should clearly state exactly with what version of eslint we dealing with. it should help to realize you use wrong version of eslint.

eg. when users file new bugs and copy error output, they can forget to include eslint version into bug description. with version injected into output it is not a problem.
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Jul 29, 2017
@platinumazure platinumazure added cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jul 29, 2017
@platinumazure
Copy link
Member

I'm absolutely 👍 to this- it could aid users in detecting if they are accidentally using global instead of local ESLint (or vice versa) and help ensure accurate bug reporting.

aladdin-add added a commit to aladdin-add/eslint that referenced this issue Aug 4, 2017
@aladdin-add
Update: add eslint version to error output. (fixes eslint#9037)
7d20564
@aladdin-add aladdin-add mentioned this issue Aug 4, 2017
Merged
@platinumazure platinumazure self-assigned this Aug 23, 2017
@platinumazure
Copy link
Member

I'll champion this.

@eslint/eslint-tsc Are CLI issues like rule issues where 3 👍's and a champion allow for accepting the issue? Or are these more like core issues where we need to have TSC review?

@btmills
Copy link
Member

btmills commented Aug 23, 2017

I had to check the issue guide, but it mentions this case:

changes to the core (including CLI changes) that would result in a minor or major version release must be approved by the TSC

Should be a pretty quick approval at the next meeting - it already has four 👍s from TSC members!

@platinumazure platinumazure removed their assignment Aug 23, 2017
@platinumazure
Copy link
Member

platinumazure commented Aug 23, 2017 •
edited

Then I don't need to champion this. 😄

TSC Summary: The purpose of this proposed change is to add the ESLint current version to error output from the CLI.

TSC Agenda: Should we accept this proposal?

@platinumazure platinumazure added the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Aug 23, 2017
ilyavolodin pushed a commit that referenced this issue Sep 1, 2017
@aladdin-add @ilyavolodin
Update: add eslint version to error output. (fixes #9037) (#9071)
6becf91 
* Update: add eslint version to error output. (fixes #9037)

* use  pkg.version.

* Fix: accept review suggestions.
@not-an-aardvark
Copy link
Member

The TSC accepted this proposal yesterday.

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion and removed tsc agenda This issue will be discussed by ESLint's TSC at the next meeting evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Sep 1, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 1, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: add eslint version to error output. (fixes #9037) aladdin-add/eslint
5 participants
@platinumazure @art-in @btmills @not-an-aardvark @eslintbot