Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclomatic Complexity rule documentation links to jscomplexity.org which is no longer available. #8396

Closed
Standard8 opened this issue Apr 3, 2017 · 4 comments · Fixed by #8937
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation good first issue Good for people who haven't worked on ESLint before

Comments

@Standard8
Copy link
Contributor

Tell us about your environment

  • ESLint Version: Latest

What did you expect to happen?

Visit the further detail links on http://eslint.org/docs/rules/complexity#further-reading and find valid sites.

What actually happened?

http://jscomplexity.org/complexity is unavailable. The second link also has links to the first one, which is unavailable.

Hence it is difficult to determine the basis for how complexity is calculated without reading the code.

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Apr 3, 2017
@gyandeeps gyandeeps added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Apr 3, 2017
@gyandeeps
Copy link
Member

Do you want to send a PR to fix it?

@Standard8
Copy link
Contributor Author

Unfortunately I don't know if there's an alternative to that site. I think the rule needs some sort of fuller description available, as otherwise you don't know how it is generated.

The best I could find was an unmaintained github repo of the original site, but I was hoping that someone would know a better place to look.

@SpadeAceman
Copy link

The Wikipedia article does a decent job of explaining McCabe's cyclomatic complexity, and what the complexity rule is generally measuring (though not how it specifically relates to Javascript).

And this article explains what the complexity rule doesn't measure in Javascript, which is helpful to know.

Finally, I found a number of other potentially helpful links when researching #4808.

@vitorbal
Copy link
Member

Thanks for the links, @SpadeAceman! Would you be willing to send a PR to add them?

@not-an-aardvark not-an-aardvark added the good first issue Good for people who haven't worked on ESLint before label Jul 11, 2017
cbargren added a commit to cbargren/eslint that referenced this issue Jul 12, 2017
cbargren added a commit to cbargren/eslint that referenced this issue Jul 12, 2017
Also added a few more useful links. These can be rolled back or pared down they're it's over-the-top.
not-an-aardvark pushed a commit that referenced this issue Jul 13, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation good first issue Good for people who haven't worked on ESLint before
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants