Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing error message when extending non-existing plugin config #6115

Closed
ganimomer opened this issue May 8, 2016 · 1 comment · Fixed by renovatebot/renovate#111 · May be fixed by iamhunter/teammates#4
Closed

Confusing error message when extending non-existing plugin config #6115

ganimomer opened this issue May 8, 2016 · 1 comment · Fixed by renovatebot/renovate#111 · May be fixed by iamhunter/teammates#4
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint

Comments

@ganimomer
Copy link

What version of ESLint are you using?
2.9.0
What parser (default, Babel-ESLint, etc.) are you using?
babel-eslint
Please show your full configuration:

{
  "parser": "babel-eslint",
  "plugins": ["lodash"],
  "extends": ["plugin:lodash/recommend", "eslint-config-airbnb"],
  "rules": {
    "indent": [2, 2, {"SwitchCase": 1}],
    "no-console": [0],
    "func-names": [0],
    "semi": [2, "never"],
    "no-extra-semi": [2],
    "space-before-function-paren": [2, "always"],
    "no-else-return": [0],
    "space-infix-ops": [0],
    "react/prefer-es6-class": [0],
    "react/prefer-stateless-function": [0]
  },
  "globals": {
    "Bugsnag": true,
    "FS": true
  }
}

What did you do? Please include the actual source code causing the issue.
This was originally an issue for the Lodash plugin, wix-incubator/eslint-plugin-lodash#76.
The user ran ESLint with the config, extending from lodash/recommend instead of lodash/recommended.
What did you expect to happen?
An error similar to the one when extending a non-existing module.
For instance:

Error: Cannot find config 'plugin:lodash/recommened' from '...'
Referenced from: <config file>
    <call stack>

What actually happened? Please include the actual, raw output from ESLint.

 TypeError: Cannot convert undefined or null to object
Referenced from: /root/RelateRocket/webapp/.eslintrc
    at Function.keys (native)
   ...
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label May 8, 2016
@kaicataldo kaicataldo added enhancement This change enhances an existing feature of ESLint cli Relates to ESLint's command-line interface evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 10, 2016
@kaicataldo
Copy link
Member

Thanks for the issue. Agreed - if we can improve this error message, we should.

@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 25, 2016
@gyandeeps gyandeeps self-assigned this Oct 11, 2016
@gyandeeps gyandeeps removed their assignment Oct 20, 2016
@alberto alberto self-assigned this Jan 29, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint
Projects
None yet
6 participants