New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests failing on current master #11062
Comments
Confirmed. This is blocking PRs right now. |
Based on the test failures this might have been caused by the recent release of |
I'll try to take a look in the few minutes of remaining energy I have. |
Related: #11052 |
It looks like the contents of I'm not sure that this has actually changed the functionality of However, if the cache file format has changed, that will cause a problem for people who have an existing cache file and then upgrade or reinstall ESLint. @royriojas any thoughts? |
hi @nzakas, I recently released a new version of the The newer Will take some time to review if that might be interpreting/serializing differently the cache, as I said, I wouldn't expect it to happen as tests passed. But it might be we're lacking one test to protect against cases like this. |
I've reverted the upgrade of Will add a test for the eslint case before attempting to upgrade again I verified master in eslint and tests pass just fine. |
Thanks @royriojas looks like we are in the clear now. |
closing, as the issue has been fixed. |
see https://ci.appveyor.com/project/nzakas/eslint/builds/20097976
The text was updated successfully, but these errors were encountered: