CircularJSON dependency warning

[theprobugmaker]

warning eslint > file-entry-cache > flat-cache > circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor.

Perhaps changing to https://github.com/WebReflection/flatted#flatted?

[not-an-aardvark]

Hi, thanks for the report. I'd recommend opening an issue on the flat-cache package instead, since that's where the circular-json dependency is declared.

[platinumazure]

Hi @zefexdeveloper, thanks for this issue.

As you can see, this is an indirect dependency. It would be more useful to file an issue in the flat-cache and/or file-entry-cache repositories to ensure they consume the new package; then ESLint can upgrade file-entry-cache to consume the new package as well.

Would you mind filing issues in those repositories? Thanks!

[platinumazure]

Looks like this is in the process of being addressed: jaredwray/flat-cache#23

[theprobugmaker]

@platinumazure Thank you for the rapid response, I saw that you comment there as well.

[royriojas]

@zefexdeveloper @platinumazure the upgrade broke the eslint build #11062, I had to revert the upgrade. Will reopen the ticket.

[theprobugmaker]

@royriojas Thank you very much, it looks like everything is good to go now right?

#11062 (comment)

[royriojas]

hi @zefexdeveloper technically not. Since the revert is forcing us to still use circular-json. I will release a new major version of flat-cache that includes the change to flatted and make a PR to upgrade the unit tests of eslint. Worst side effect I believe this could introduce is that during the upgrade the previous cache format won't be read correctly and will be discarded.

I need to confirm that is the behavior, it would be in my opinion the best way to handle the obsolete cache format.

[platinumazure]

I'll reopen this.

@royriojas Kind of weird that flatted writes JSON differently for the same input when flatted is supposed to be the replacement for circular-json. Maybe their API is a bit different. Does flatted have documentation around a migration path from circular-json, I wonder?

At any rate, I think there's probably a way to preserve the current cache format... somehow 😄 We just need to find it!

If I get time this weekend, I can try to help dig in. Sorry I didn't provide a lot of help on the initial upgrade attempt.

[theprobugmaker]

I'm sorry for closing the issue, I really thought it was done, I was traveling and when I went back to work I tried to update and noticed that it wasn't.

[eslint-deprecated]

Unfortunately, it looks like there wasn't enough interest from the team
or community to implement this change. While we wish we'd be able to
accommodate everyone's requests, we do need to prioritize. We've found
that issues failing to reach accepted status after 21 days tend to
never be accepted, and as such, we close those issues.
This doesn't mean the idea isn't interesting or useful, just that it's
not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.

[ghost]

it's not something the team can commit to.

I guess that's ONE way to reduce your bug count.

[theprobugmaker]

@platinumazure @royriojas What happened to this issue?

[royriojas]

The issue was just closed automatically it seems.

@zefexdeveloper Nothing yet, the PR that added circular json is fine and should be merged back to master, but we need to fix the tests in eslint to not read directly the cache file but use the flatted module to get the values to verify the cache works.

I will try to find some time during this weekend.

[platinumazure]

@royriojas If the underlying cache file has changed, how will the new code be able to correctly read the cache files created before this upgrade? Unless you have an answer for that, I really think we need to look into how to avoid the cache file changing.

[not-an-aardvark]

Currently, ESLint invalidates cache files that were created by a previous version of ESLint anyway. So I think changing the cache file format would be fine provided that ESLint still works gracefully (e.g. by pretending the file doesn't exist rather than crashing) when an updated version of ESLint sees a cache file of the old format, and vice versa.

[xiaomizhou66]

留个脚印

[nzakas]

Sorry, this shouldn't have been closed. We still need to resolve this.

[royriojas]

@nzakas the dependencies were updated. To avoid an issue with eslint I release them as major versions. So the only thing left is to change the tests so we don't rely on the format. We might be able to use flatted to read the content in the cache and make the tests pass. If nobody does it I can take care of it tomorrow.

[nzakas]

That sounds great, if you don't mind submitting a PR, we can take a look.

…

On Wed, Jan 16, 2019 at 10:10 AM Roy Riojas ***@***.***> wrote: @nzakas <https://github.com/nzakas> the dependencies were updated. To avoid an issue with eslint I release them as major versions. So the only thing left is to change the tests so we don't rely on the format. We might be able to use flatted to read the content in the cache and make the tests pass. If nobody does it I can take care of it tomorrow. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#11052 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACWkopO7ZjeXvo92uZq927Istzfqr_aks5vD2ssgaJpZM4YNGNm> .

--

______________________________ Nicholas C. Zakas @SlickNet Author, Principles of Object-Oriented JavaScript <http://amzn.to/29Pmfrm> Author, Understanding ECMAScript 6 <http://amzn.to/29K1mIy>

[alexisargyris]

Could somebody please have a look at this and close it? Thanks in advance.

[lxe]

Any news on this? How's #11314 doing?

[nzakas]

Thanks for your interest, everyone. Please note that updates are always posted onto the issue when there are updates to share, so there is no need to ask if there are updates.

The currently open pull request (#11314) has feedback outstanding on it, so I'd encourage you to follow that PR to see the latest.

Keep in mind that while a deprecation warning might be annoying, it doesn't mean ESLint isn't working correctly or that there is any security concern with the existing dependency.

[adewale2018]

Please, how can I get rid of this error?
npm WARN deprecated circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor.

[not-an-aardvark]

Try upgrading to the latest version of ESLint.